-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[WIP]Drop support of root namespace in routing #4996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Drop support of root namespace in routing #4996
Conversation
|
Coverage decreased (-37.45%) when pulling 5daabed6ca3bfa50619794cbbbdde828a9a933b4 on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master. |
|
Good idea. However test fails :( |
|
Sorry, I have tested rspec, but not spinach. |
|
Coverage decreased (-20.83%) when pulling 5e3bf78281c8cacc65a7cdeaa8ef6adfc7008f61 on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master. |
|
Coverage decreased (-13.52%) when pulling 17a889e4fcdf7bd5b148c8cdbf2a76ec7265b6e5 on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master. |
|
Coverage decreased (-13.27%) when pulling 8119692490b0e509bf2e2ce08250f302796520dd on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master. |
|
Coverage decreased (-13.38%) when pulling 33a8072d8a91d4122706d648afc767d9c50d19d9 on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master. |
|
Coverage decreased (-13.79%) when pulling 98bd7a39d0056436f8e907dab8cecd74cb928380 on hiroponz:drop-support-of-root-namespace into b349af2 on gitlabhq:master. |
|
API specs left :) |
|
Coverage decreased (-14.54%) when pulling 57bb22085e0ab214a841e424aa7a7d3b6b734b2c on hiroponz:drop-support-of-root-namespace into b349af2 on gitlabhq:master. |
|
@randx No errors occur in my vagrant machine. Any idea? |
|
@hiroponz maybe travis issue. I'll run specs on my machine later |
|
@randx thanks 😄 |
[WIP]Drop support of root namespace in routing
|
@hiroponz tests passes locally. thanks |
Fixes #5144 Refs gitlabhq#4996
No description provided.