Skip to content

Conversation

@hiroponz
Copy link
Contributor

@hiroponz hiroponz commented Sep 5, 2013

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-37.45%) when pulling 5daabed6ca3bfa50619794cbbbdde828a9a933b4 on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master.

@dzaporozhets
Copy link
Contributor

Good idea. However test fails :(

@hiroponz
Copy link
Contributor Author

hiroponz commented Sep 5, 2013

Sorry, I have tested rspec, but not spinach.
It needs some bug fixes.

@coveralls
Copy link

Coverage Status

Coverage decreased (-20.83%) when pulling 5e3bf78281c8cacc65a7cdeaa8ef6adfc7008f61 on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.52%) when pulling 17a889e4fcdf7bd5b148c8cdbf2a76ec7265b6e5 on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.27%) when pulling 8119692490b0e509bf2e2ce08250f302796520dd on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.38%) when pulling 33a8072d8a91d4122706d648afc767d9c50d19d9 on hiroponz:drop-support-of-root-namespace into 9109a20 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.79%) when pulling 98bd7a39d0056436f8e907dab8cecd74cb928380 on hiroponz:drop-support-of-root-namespace into b349af2 on gitlabhq:master.

@dzaporozhets
Copy link
Contributor

API specs left :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-14.54%) when pulling 57bb22085e0ab214a841e424aa7a7d3b6b734b2c on hiroponz:drop-support-of-root-namespace into b349af2 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-14.66%) when pulling df9cbbc on hiroponz:drop-support-of-root-namespace into e1ca9de on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-17.19%) when pulling 553841e on hiroponz:drop-support-of-root-namespace into e1ca9de on gitlabhq:master.

@hiroponz
Copy link
Contributor Author

@randx No errors occur in my vagrant machine. Any idea?

@dzaporozhets
Copy link
Contributor

@hiroponz maybe travis issue. I'll run specs on my machine later

@hiroponz
Copy link
Contributor Author

@randx thanks 😄

dzaporozhets added a commit that referenced this pull request Sep 14, 2013
[WIP]Drop support of root namespace in routing
@dzaporozhets dzaporozhets merged commit 2898d92 into gitlabhq:master Sep 14, 2013
@dzaporozhets
Copy link
Contributor

@hiroponz tests passes locally. thanks

@hiroponz hiroponz deleted the drop-support-of-root-namespace branch September 14, 2013 15:25
hiroponz added a commit to hiroponz/gitlabhq that referenced this pull request Sep 21, 2013
@hiroponz hiroponz mentioned this pull request Sep 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants