New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor omniauth configuration method #5957

Merged
merged 2 commits into from Feb 1, 2014

Conversation

6 participants
@luxflux
Contributor

luxflux commented Dec 30, 2013

This refactoring allows a user to use omniauth providers which do not
use app_id and app_secret without having to change the
devise configuration (simplifies all the custom omniauth provider usage described here )

refactor omniauth configuration method
This refactoring allows a user to use omniauth providers which do not
use ```app_id``` and ```app_secret``` without needing to change the
devise configuration.
@pencil

This comment has been minimized.

Show comment
Hide comment
@pencil

pencil commented Dec 30, 2013

👍

@veidt

This comment has been minimized.

Show comment
Hide comment
@veidt

veidt Jan 3, 2014

👍

I have added Atlassian Crowd as an omniauth provider based off of this pull-request. I'll submit my own when this one is finalized.

veidt commented Jan 3, 2014

👍

I have added Atlassian Crowd as an omniauth provider based off of this pull-request. I'll submit my own when this one is finalized.

@luxflux

This comment has been minimized.

Show comment
Hide comment
@luxflux

luxflux Jan 13, 2014

Contributor

Any news here?

Contributor

luxflux commented Jan 13, 2014

Any news here?

@dosire

This comment has been minimized.

Show comment
Hide comment
@dosire

dosire Jan 15, 2014

Member

@randx Can you look into this? Crowd integration would be awesome and this is needed for it.

Member

dosire commented Jan 15, 2014

@randx Can you look into this? Crowd integration would be awesome and this is needed for it.

Merge branch 'master' into dont-depend-on-appid-and-appsecret
* master: (238 commits)
  Version 6.5.1
  Fix selectbox when submit MR from fork to origin
  Fix HELP layout
  No need for code tag here.
  Spelling mistake and add links.
  Warn against RVM.
  Remove GitHub mention because we also have a GitLab issue tracker now.
  Replace 6.0-to-6.4.md with 6.0-to-6.5.md
  Add public assets to gitignore
  Version 6.5.0
  Use 6-5 branch in installation docs
  Remove deprecated twitter handle.
  Further explain userPrincipalName settings
  Update from 6.4 to 6.5 guide
  Explain how to use AD userPrincipalName for logins
  More entries to CHANGELOG. Version to rc1
  Rephrase LDAP check script output
  add O'Reilly sponsorship in CHANGELOG
  Fix select2 css for drop above style
  Rename "Website url" labels to "Website"
  ...
@calmyournerves

This comment has been minimized.

Show comment
Hide comment
@calmyournerves

calmyournerves commented Jan 23, 2014

:shipit:

@luxflux

This comment has been minimized.

Show comment
Hide comment
@luxflux

luxflux Jan 23, 2014

Contributor

Another try for the next Release 😄

Contributor

luxflux commented Jan 23, 2014

Another try for the next Release 😄

@pencil

This comment has been minimized.

Show comment
Hide comment
@pencil

pencil Jan 23, 2014

10/10, would merge!

pencil commented Jan 23, 2014

10/10, would merge!

@dzaporozhets

This comment has been minimized.

Show comment
Hide comment
@dzaporozhets

dzaporozhets Feb 1, 2014

Member

Looks good

Member

dzaporozhets commented Feb 1, 2014

Looks good

dzaporozhets added a commit that referenced this pull request Feb 1, 2014

@dzaporozhets dzaporozhets merged commit 5db3468 into gitlabhq:master Feb 1, 2014

1 check passed

default The Travis CI build passed
Details

@luxflux luxflux deleted the ninech:dont-depend-on-appid-and-appsecret branch Feb 1, 2014

@dosire

This comment has been minimized.

Show comment
Hide comment
@dosire

dosire Feb 4, 2014

Member

@veidt Can you link to your MR for Atlassian Crowd? It would be awesome to have that in too.

Member

dosire commented Feb 4, 2014

@veidt Can you link to your MR for Atlassian Crowd? It would be awesome to have that in too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment