Remove deprecated finders #6075

Merged
merged 1 commit into from Jan 22, 2014

Conversation

Projects
None yet
3 participants
@skv-headless
Contributor

skv-headless commented Jan 16, 2014

No description provided.

@jvanbaarsen

This comment has been minimized.

Show comment Hide comment
@jvanbaarsen

jvanbaarsen Jan 19, 2014

Contributor

Can you please make sure the tests are passing? And maybe for the next PR, make it in little chunks. This way its super hard to review 😄

Contributor

jvanbaarsen commented Jan 19, 2014

Can you please make sure the tests are passing? And maybe for the next PR, make it in little chunks. This way its super hard to review 😄

@skv-headless

This comment has been minimized.

Show comment Hide comment
@skv-headless

skv-headless Jan 19, 2014

Contributor

This way its super hard to review. Sorry for that.
Mysql2::Error: Data too long for column 'st_diffs'. Actually I don't know why it had happened on my build. At my computer all test are passed, but on postgresql.

Contributor

skv-headless commented Jan 19, 2014

This way its super hard to review. Sorry for that.
Mysql2::Error: Data too long for column 'st_diffs'. Actually I don't know why it had happened on my build. At my computer all test are passed, but on postgresql.

@jvanbaarsen

This comment has been minimized.

Show comment Hide comment
@jvanbaarsen

jvanbaarsen Jan 19, 2014

Contributor

@randx Can you take a look?

Contributor

jvanbaarsen commented Jan 19, 2014

@randx Can you take a look?

@dzaporozhets

This comment has been minimized.

Show comment Hide comment
@dzaporozhets

dzaporozhets Jan 19, 2014

Owner

db/schema was modified. Please rollback it

Owner

dzaporozhets commented Jan 19, 2014

db/schema was modified. Please rollback it

@jvanbaarsen

This comment has been minimized.

Show comment Hide comment
@jvanbaarsen

jvanbaarsen Jan 19, 2014

Contributor

@skv-headless Can you take another look at the tests? Since they now fail on another feature.

Contributor

jvanbaarsen commented Jan 19, 2014

@skv-headless Can you take another look at the tests? Since they now fail on another feature.

@dzaporozhets

This comment has been minimized.

Show comment Hide comment
@dzaporozhets

dzaporozhets Jan 20, 2014

Owner

@skv-headless thank you. Will return to it after 6.5 release

Owner

dzaporozhets commented Jan 20, 2014

@skv-headless thank you. Will return to it after 6.5 release

@ghost ghost assigned dzaporozhets Jan 20, 2014

dzaporozhets added a commit that referenced this pull request Jan 22, 2014

@dzaporozhets dzaporozhets merged commit 4d56c35 into gitlabhq:master Jan 22, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment