Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit message textareas have 72 char mark line. #6385

Merged
merged 1 commit into from May 13, 2014

Conversation

6 participants
@cirosantilli
Copy link
Contributor

commented Feb 22, 2014

Fixes ACCEPTING MR at: http://feedback.gitlab.com/forums/176466-general/suggestions/5337507-show-72-character-mark-in-commits?tracking_code=284b0e5fd832f6885a68d90447c08d2a

All textareas that take a commit message now have the same monospace font in which they are shown under the commits tab, and a 72 character width vertical marker line.

I have only found commit message textareas in the following places:

  • new, edit and remove file from web interface views.
  • merge request custom commit message

Please notify me if there are any more of them.

screenshots

Edit file:

screenshot from 2014-02-22 18 48 18 edit

New file is analogous.

The remove popup had to be made wider because it did not have place for 72 characters before:

screenshot from 2014-02-22 20 23 08 rm

Custom MR commit message:

screenshot from 2014-02-22 18 52 21 mr

doubts

How to use exactly the same Bootstrap values of textarea.form-control padding-left for .max-width-marker left?

I could not find it, so I just set hardcoded the current Bootstrap value of 12px for both the padding and the left.

This way it will never break, but it will not evolve automatically if the page style is modified.

One possibility to solve this is to set all missing values ourselves in our SASS via variables to their current values so that those variables can be used in other places.

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2014

All tests passed locally. Travis tests failed either because of the 50min limit, or because some package failed to install at startup.

@dosire

This comment has been minimized.

Copy link
Member

commented Feb 24, 2014

Thanks @cirosantilli

@randx Can you review this?

@dblessing

This comment has been minimized.

Copy link
Member

commented Mar 27, 2014

@cirosantilli Can you make your pull request mergeable, please? Ping me when that's done and we will have randx take a look. Thanks!

@drewblessing

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2014

@cirosantilli I don't want to see this one die. I know a lot of people have requested this. Can you please rebase and we'll see if we can get this merged? :) Thanks!

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2014

@drewblessing sorry about the delay. I got caught up in preparation for Google programming competition for Saturday, but after that I am certainly going to update this!

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2014

OMG, Hound didn't bark! Lets see if this makes it for next merge window.

@jvanbaarsen

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2014

@randx Looks good to merge

@dblessing

This comment has been minimized.

Copy link
Member

commented May 11, 2014

@randx Looks good. What do you think?

@dzaporozhets

This comment has been minimized.

Copy link
Member

commented May 13, 2014

Look good. Thanks

dzaporozhets added a commit that referenced this pull request May 13, 2014

Merge pull request #6385 from cirosantilli/72-char-commit-msg
Commit message textareas have 72 char mark line.

@dzaporozhets dzaporozhets merged commit 0401e19 into gitlabhq:master May 13, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@cirosantilli cirosantilli deleted the booktree:72-char-commit-msg branch May 13, 2014

@dosire

This comment has been minimized.

Copy link
Member

commented May 13, 2014

@cirosantilli Congrats and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.