New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue and MR descriptions have white background. #6389

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Feb 23, 2014

  • more uniform with other places that render large chunks of markdown
  • easier to distinguish title and metadata from main description. We already have the vertical border to visually unite the metadata with the description.
  • more similar to GitHub: cirosantilli/test-git-web-interface#5

New:

screenshot from 2014-02-23 12 29 55 new

Old:

screenshot from 2014-02-23 12 15 42 old

Analogous for MRs and milestones.

Implementation Notes

If the background is white, it becomes apparent that there is no padding-top and no border-top, so some was added to the description.

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Feb 23, 2014

@cirosantilli I like the new looks 😄 👍

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Feb 25, 2014

I prefer old one. Title and description are not separated and looks more natural

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Feb 25, 2014

in compare to your old screenshot
screenshot 2014-02-25 10 51 59

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Feb 25, 2014

What about making the content just a white background. I thinks that a bonus point for GitHub (i like the clean look of white here :-)

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Feb 25, 2014

What about we give title white background too? (and remove the separating line). At least will contrast more from metadata on bottom.

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Feb 25, 2014

@cirosantilli Yeah that was what i meant :-)

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Feb 27, 2014

How about this?
screenshot 2014-02-27 17 36 38

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Feb 27, 2014

And red one
screenshot 2014-02-27 17 39 06

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Feb 27, 2014

@randx, I like it!

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Feb 27, 2014

I like it too.

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Feb 28, 2014

Fxied by 9114cfb

@cirosantilli cirosantilli deleted the booktree:description-white-background branch Mar 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment