Skip to content

Added Rails Environment Relative URL #642

Closed
wants to merge 1 commit into from

6 participants

@nsteffan
nsteffan commented Apr 4, 2012

Added a scope to enable the ability to use a context root on the application.

@vsizov
vsizov commented Apr 4, 2012

I don`t agree.
@randx what do you think?

@randx
GitLab member
randx commented Apr 4, 2012

I dont like this either

@vsizov vsizov closed this Apr 5, 2012
@nsteffan
nsteffan commented Apr 5, 2012

Not to be annoying, but what don't you agree with? This seems to be the accepted way for a Rails 3 application to be put at a directory other than '/' since the removal of config.action_controller.relative_url_root.

@vsizov
vsizov commented Apr 5, 2012

we don`t support relative url. Also it looks dirty.

@vsizov
vsizov commented Apr 5, 2012

i mean we don`t want support of relative url.

@nsteffan
nsteffan commented Apr 5, 2012

I realize that as an open source project I have the freedom to change the code and use it as I see fit.

That being said, an open source project should be able to be customized easy enough so someone can integrate said project into their own environment without a lot of trouble. It should have been a lot easier for me to integrate this application into my environment and looking at other discussion topics on Google it seems like I wasn't the only one that was looking for this functionality in this project.

If you aren't going to include this functionality in the project natively, I would suggest creating a wiki page stating how it can be done so people don't spend hours like I did trying to figure out why I couldn't make it work properly.

@vsizov
vsizov commented Apr 5, 2012

yes. Manual or wiki page will be good idea. But this feature shouldn't be in core logic. Because it will make more hardly support our product. Sorry for my english. Do not be offended.

@randx
GitLab member
randx commented Apr 5, 2012

Manual or wiki is ok. But core functionality should be tiny

@jordanorc

Several other projects like Redmine support this functionality. There are several situations where you create a subdomain just for the installation of a system is not possible, nor advisable. Sorry for my English ... but I agree that this is a necessary feature. I agree too that "nsteffan" propose of implementation is ugly. Maybe someone could see how Redmine do this and apply this feature to gitlabhq!

@kjellski
kjellski commented Nov 2, 2012

What am I supposed to do when I can't subdomain and need this functionality? Is there a way to make it behave nevertheless? I can't run this on a complete host on its own.

@frohoff
frohoff commented Dec 11, 2012

I've created a pull request with an alternate implementation of relative url root support in #2162 .

@gierschv gierschv referenced this pull request in gitlabhq/gitlab-ci Jan 29, 2013
Merged

Added Rails Environment Relative URL #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.