Skip to content

Conversation

@razielgn
Copy link
Contributor

Let me know what I can do better here. :)

@maxlazio
Copy link
Member

👍

dzaporozhets added a commit that referenced this pull request Mar 19, 2014
@dzaporozhets dzaporozhets merged commit 11a56cc into gitlabhq:master Mar 19, 2014
@dzaporozhets
Copy link
Contributor

👍

@dzaporozhets
Copy link
Contributor

really like slack :)

@razielgn
Copy link
Contributor Author

Thanks. :)

@rtripault
Copy link
Contributor

@razielgn thanks for letting me discover that nice service!

Anyway, i feel dumb about how to make the Gitlab service run, would you mind providing basic guidelines ?

Thanks

@razielgn
Copy link
Contributor Author

@rtripault You're right, it's a bit tricky at the moment.
Right now it must be used via "DIY Incoming Webhooks" (https://team.slack.com/services/new/incoming-webhook).
I've got in touch with the Slack team: they're going to add Gitlab to the list of "supported services", with visibility, a nice icon and name, plus instructions on how to enable it.
They've also told me we should slightly modify the HTTP endpoint once they do that. Since I've used slack-notifier, I've opened a PR at slack-notifier/slack-notifier#2, so as soon as it gets merged I'll send a new PR here.

@rtripault
Copy link
Contributor

Makes sense!
I guess it might be obvious for people used to Slack (which is not my case -- yet).

So once again, thanks a lot for everything 👍

@jimmybrancaccio
Copy link

@razielgn This definitely looks awesome! I've just signed up for Slack and it's awesome. I tried adding the incoming-webhook manually as you described, I did a test push, but nothing seems to be coming in. I assume this will work nicely when they add GitLab as an integration though. Great work!! 👍 😄

@dzaporozhets
Copy link
Contributor

@jimmybrancaccio Room must start from #. Ex #general.
screenshot 2014-03-20 11 14 28

@jimmybrancaccio
Copy link

@randx I won't turn this into a 'Help Me' thread 😝 Since I am on 6.6 I had to use the DIY Incoming Webhooks, which wasn't working for me but I think I'll just wait for the awesomeness in 6.7 so I can do it correctly.

I should also ask, since some rooms (private rooms) don't start with #, will this still work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants