New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown styleguide. #6795

Merged
merged 1 commit into from Apr 23, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Apr 16, 2014

Fixes ACCEPTING MR at: http://feedback.gitlab.com/forums/176466-general/suggestions/5757956-add-markdown-style-guidelines-for-documentation-to

I'll give great priority to GitLab Team's issues on that repository.

@@ -113,3 +113,4 @@ For examples of feedback on merge requests please look at already [closed merge
8. [Testing](https://github.com/thoughtbot/guides/tree/master/style#testing)
7. [CoffeeScript](https://github.com/thoughtbot/guides/tree/master/style#coffeescript)
9. [Shell commands](doc/development/shell_commands.md)
1. [Markdown](https://github.com/cirosantilli/markdown-styleguide)

This comment has been minimized.

@dosire

dosire Apr 16, 2014

Member

Can you change the number to 10 or renumber all to 1.?

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Apr 17, 2014

@cirosantilli What is the reason to fork the original repo?

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Apr 17, 2014

@cirosantilli Ok thanks :)

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Apr 17, 2014

@randx Looks good to merge!

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Apr 21, 2014

Moved link to my github.io so we can have a js generated TOC.

dzaporozhets added a commit that referenced this pull request Apr 23, 2014

@dzaporozhets dzaporozhets merged commit 2876f5d into gitlabhq:master Apr 23, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Oct 1, 2018

Lock prometheus version independent of data in the database
Because as we discovered in gitlabhq#6795 the prometheus install may have failed
in the past and we therefore have an old version when trying to install.
In future we'd like to address this in a better way by [handling
upgrades](https://gitlab.com/gitlab-org/gitlab-ee/issues/6817) of
prometheus versions but before then we need to [clean the data and
correctly use this `version` column from the
DB](https://gitlab.com/gitlab-org/gitlab-ee/issues/6816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment