Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant signin link from signin page. #6892

Merged
merged 1 commit into from May 1, 2014

Conversation

4 participants
@cirosantilli
Copy link
Contributor

commented Apr 29, 2014

The sign in link points to the page itself, and makes it seem like users have to go somewhere else to signin.

screenshot from 2014-04-30 21 44 44

@jvanbaarsen

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2014

@cirosantilli The problem with this fix, is that when you're on the sign-up page, the text looks a little weird maybe. I dont really think that this is a real issue. @dblessing What do you think?

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2014

@jvanbaarsen sorry, I don't quite understand why "Sign in" looks weird and, say, "GitLab" does not.

If we leave the link, people will click it, and it will be an useless click as it redirects to the same page.

In any case, it's not a major issue =)

@dblessing

This comment has been minimized.

Copy link
Member

commented May 1, 2014

It's not a major issue but I'm comfortable with the change. On the sign up page there is a Sign In link at the bottom "Have an account? Sign in"

@jvanbaarsen

This comment has been minimized.

Copy link
Contributor

commented May 1, 2014

@dblessing Ok fair enough!
@randx Looks good to merge

dzaporozhets added a commit that referenced this pull request May 1, 2014

Merge pull request #6892 from cirosantilli/remove-signin-link-front-page
Remove redundant signin link from signin page.

@dzaporozhets dzaporozhets merged commit 7660290 into gitlabhq:master May 1, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@cirosantilli cirosantilli deleted the booktree:remove-signin-link-front-page branch May 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.