New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help link to header. #6897

Merged
merged 1 commit into from May 1, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Apr 30, 2014

  • people may need help from any page
  • it is not obvious that help is under Dashboard:
    • when I first used GitLab, I clearly remember spending some time looking for the help.
    • the help URL is just /help, and not /dashboard/projects or /dasboard/issues, indicating that in the mind of the community, Help is not a part of /dashboard
  • GitHub does it, so its probably a good design choice and GitHub users will be home

Screenshots

screenshot from 2014-04-30 12 26 03

screenshot from 2014-04-30 12 26 22

Hover still perceptibly changes link color on dark theme. On white theme, like before this PR link color is unchanged on hover.

screenshot from 2014-04-30 12 26 28

Details

  • made help bold and clear on the dark theme to make it more visible and coherent with the icons on the right
  • made header-font used in the .title "Diaspora / Diaspora Title" a bit larger or else help would be more visible than it

Questions

If you like this, how about also adding a Blog link on another PR? Very important stuff, and GitHub puts it up there.

@dblessing

This comment has been minimized.

Member

dblessing commented Apr 30, 2014

I'm not opposed to the idea of this but it does stand out a bit. What about a ? icon in the list to the right?

Also, where would a blog link point to? GitLab isn't GitHub so we don't strive to do all that they do :) If it makes sense, though, we can look at it.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Apr 30, 2014

Do you mean immediately to the right of the search bar? Right of search bar might be more logical than current position, as it would put this new link together with the other ones (icons).

The blog link could point to either https://www.gitlab.com/blog/ or https://www.gitlab.com . Agree that "GitHub does it" does not imply that GitLab must do it too, but this feature in particular GitLab and any of its forks does have: a company / people behind it.

Both of those links are already present at bottom of the sidebar at the dashboard, but to me the do not have enough visibility, and like every other website out there, they should figure in every page of the website IMHO.

Related proposal for the blog link at every footer at: http://feedback.gitlab.com/forums/176466-general/suggestions/5588477-add-footer-with-contact-company-terms-of-service . If prefer it on the header now.

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Apr 30, 2014

Thanks. I agree help link may be more useful at header. But a) it should be icon not text. b) it should not modify existing css. Please stop do changes not related to actual PR goal

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Apr 30, 2014

Sorry, I did try to keep it to a minimum: I judged both CSS changes made were necessary as explained in Details because this is the first non-icon link on the header, and it would be too hard to read it otherwise. I would not have changed it if I had added another icon, and since you think its not that necessary I'll undo those changes.

I would rather have text as it is:

  • easier to spot and understand by new users
  • searchable
  • generalizes better. How would we represent a "Blog" link?

but if this is the final decision by GitLab Team I'll stick to it. In that case, which icon shall we use? fa-question?

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented May 1, 2014

Ok I see your point. but i will accept only icon. And it will be no blog link.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented May 1, 2014

screenshot from 2014-05-01 09 12 46

dzaporozhets added a commit that referenced this pull request May 1, 2014

@dzaporozhets dzaporozhets merged commit d4b4088 into gitlabhq:master May 1, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented May 1, 2014

@cirosantilli thanks

@dblessing

This comment has been minimized.

Member

dblessing commented May 2, 2014

@randx We need to remember to make this work in the mobile menu, too. I'll try to remember to do a PR.

@dblessing

This comment has been minimized.

Member

dblessing commented May 2, 2014

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/92 addresses the mobile menu after adding the help link.

dzaporozhets added a commit that referenced this pull request May 7, 2014

Merge branch 'mobile_menu_help' into 'master'
Fix mobile menu after adding help link

After #6897 the mobile menu ran off the left side of the screen. I don't see much we can do to squeeze all the items into mobile's width. I think hiding one of the items is acceptable and which is a matter of opinion.  I suggest hiding the user's avatar on mobile but the search icon or help icon would both be options as well. Let me know if you want a different icon hidden on mobile.

[Before Screenshot](https://www.dropbox.com/s/hnfmaln3ilcy0p7/Screen%20Shot%202014-05-02%20at%205.17.28%20PM.png)
[After Screenshot](https://www.dropbox.com/s/3ifxa8gfa12h37h/Screen%20Shot%202014-05-05%20at%204.52.25%20AM.png)
@arif-ali

This comment has been minimized.

Contributor

arif-ali commented May 8, 2014

I've just updated to master branch, and I see the new icon, but is it worth having the help tab as well as the icon at the top, as in the image below
screenshot from 2014-05-08 22 40 28

If that is in the design and it is intended, then great.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented May 8, 2014

@arif-ali the icon was added by this PR, and as far as I know the Help tab under the Dashboard will remain untouched as in the current master.

@cirosantilli cirosantilli deleted the booktree:help-every-page branch May 8, 2014

@dblessing

This comment has been minimized.

Member

dblessing commented May 11, 2014

@arif-ali The help tab is only available from the dashboard. I think it is OK. It's nice to have a very prominent "Help" available on the landing page. Other pages can access help from the icon bar. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment