Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add help link to header. #6897
Hover still perceptibly changes link color on dark theme. On white theme, like before this PR link color is unchanged on hover.
If you like this, how about also adding a Blog link on another PR? Very important stuff, and GitHub puts it up there.
I'm not opposed to the idea of this but it does stand out a bit. What about a ? icon in the list to the right?
Also, where would a blog link point to? GitLab isn't GitHub so we don't strive to do all that they do :) If it makes sense, though, we can look at it.
Do you mean immediately to the right of the search bar? Right of search bar might be more logical than current position, as it would put this new link together with the other ones (icons).
The blog link could point to either https://www.gitlab.com/blog/ or https://www.gitlab.com . Agree that "GitHub does it" does not imply that GitLab must do it too, but this feature in particular GitLab and any of its forks does have: a company / people behind it.
Both of those links are already present at bottom of the sidebar at the dashboard, but to me the do not have enough visibility, and like every other website out there, they should figure in every page of the website IMHO.
Related proposal for the blog link at every footer at: http://feedback.gitlab.com/forums/176466-general/suggestions/5588477-add-footer-with-contact-company-terms-of-service . If prefer it on the header now.
Sorry, I did try to keep it to a minimum: I judged both CSS changes made were necessary as explained in Details because this is the first non-icon link on the header, and it would be too hard to read it otherwise. I would not have changed it if I had added another icon, and since you think its not that necessary I'll undo those changes.
I would rather have text as it is:
but if this is the final decision by GitLab Team I'll stick to it. In that case, which icon shall we use?
added a commit
this pull request
May 1, 2014
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/92 addresses the mobile menu after adding the help link.