New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that bbastov is the style of Hound CI 2. #7107

Merged
merged 2 commits into from Jun 10, 2014

Conversation

2 participants
@cirosantilli
Contributor

cirosantilli commented Jun 10, 2014

Continued from #6786

Added Rubocop link.

Set option B, previous line.


Since I wrote this, Hound docs improved. They say their default is:

If you break up a chain of method invocations, keep each method invocation on its own line. Place the . at the end of each line, except the last.

I don't think bbastov specifies one method per line, so in theory Hound should check more like "Option B + one method per line."

In practice however hound does not seem to enforce one method by line by default, so it ends up being the same as bbastov because of that bug.

For now we can leave Option B.

For the future I propose we use one single tool and the style that comes with it to reduce the probability of conflicts between the styles, so either:

dosire added a commit that referenced this pull request Jun 10, 2014

Merge pull request #7107 from cirosantilli/clarify-hound-ci-style
Clarify that bbastov is the style of Hound CI 2.

@dosire dosire merged commit 19a9d9d into gitlabhq:master Jun 10, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@dosire

This comment has been minimized.

Member

dosire commented Jun 10, 2014

Thanks @cirosantilli

I think Hound uses Rubocop internally.

@cirosantilli cirosantilli deleted the cirosantilli:clarify-hound-ci-style branch Jun 10, 2014

@cirosantilli

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment