Skip to content

Conversation

@zzet
Copy link
Contributor

@zzet zzet commented Jun 18, 2014

  1. Issue may be not only in jira.
  2. Rewrite method for support different external issue trackers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [85/80]

@jvanbaarsen
Copy link
Contributor

I'm not really sure why this fix is needed? Can you please explain what does this fix?

@zzet
Copy link
Contributor Author

zzet commented Jun 20, 2014

@jvanbaarsen as you can see in config file gitlab support integration with different external issues trackers, not only JIRA. In our case it's Redmine. I don't think, that correct separate default gitlab and external issues trackers as Gitlab & JIRA. This code fix this misunderstanding.

@jvanbaarsen
Copy link
Contributor

@zzet Ok :-) I thought you meant that something was broken. Thanks for explaining!

@zzet
Copy link
Contributor Author

zzet commented Jun 20, 2014

@jvanbaarsen no ;) only fix incorrect method name

@jvanbaarsen
Copy link
Contributor

@zzet Can you please make this MR mergeable again? Thanks :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected.

1. Issue may be not only in jira.
2. Rewrite method for support different external issue trackers
@zzet
Copy link
Contributor Author

zzet commented Jun 23, 2014

@jvanbaarsen done

@KSDaemon
Copy link

We are also unhappy, that from 6.9.0 release we can not have links to our redmine issues right from gitlab.

@zzet
Copy link
Contributor Author

zzet commented Jun 30, 2014

@KSDaemon this PR resolve your problem.

@KSDaemon
Copy link

Yep. For now i've just patched our instance — works well. But this diff is outdated and require some modifications.

@KSDaemon
Copy link

KSDaemon commented Jul 8, 2014

Hmm... I don't know what happens, but it seems, that this doesn't work good. As i can see, it renders url not in all places. Sometimes it just ignore it. Even in the same project, same bugfix id, just different commits.

@zzet
Copy link
Contributor Author

zzet commented Jul 8, 2014

@KSDaemon you can provide more accurate and detailed information, in order that I could see?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this line to

url = url_for_issue(identifier, project)

or it showed no url in dashboard like this

<a class="gfm gfm-issue " href title="Issue in Redmine">33944</a>
blablabla
<a>

@zzet
Copy link
Contributor Author

zzet commented Jul 11, 2014

@jvanbaarsen I'm on vacation from Monday. If you get any questions or concerns, I think that my colleague (@skv-headless) will help with this PR.

@jvanbaarsen
Copy link
Contributor

@zzet What is the status of this PR? Are you still working on this?

@zzet
Copy link
Contributor Author

zzet commented Aug 16, 2014

@jvanbaarsen I'll check @qqshfox feedback at Monday and report about PR.

@jvanbaarsen
Copy link
Contributor

@zzet Ok thanks! 🍰

Fix mistake by @qqshfox report
@zzet
Copy link
Contributor Author

zzet commented Aug 18, 2014

@jvanbaarsen I have made changes in accordance with the remark. I think that's nothing more to do in this PR.

@bwrsandman
Copy link

Hi, I tested this patch and it works well so 👍

Could you fix a little gripe, the # gets lost after conversion. Can you change on L241:

link_to("#{identifier}", url, options)

to

link_to("##{identifier}", url, options)

Add missing '#'
@bwrsandman
Copy link

@zzet Thank you!

@zzet
Copy link
Contributor Author

zzet commented Aug 19, 2014

@bwrsandman Thank you 👍

@maxlazio
Copy link
Member

This PR will be reviewed after 7.2 release which is due on the 22nd of August 2014.

@zzet
Copy link
Contributor Author

zzet commented Sep 4, 2014

@jvanbaarsen @maxlazio @randx ping

@dzaporozhets
Copy link
Contributor

@maxlazio will look on it and merge if ok

maxlazio added a commit that referenced this pull request Sep 8, 2014
Update markdown reference to external issues
@maxlazio maxlazio merged commit 3131d06 into gitlabhq:master Sep 8, 2014
@maxlazio
Copy link
Member

maxlazio commented Sep 8, 2014

Thanks

maxlazio added a commit that referenced this pull request Dec 4, 2015
Update markdown reference to external issues
Conflicts:
	lib/gitlab/markdown.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

8 participants