-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Update markdown reference to external issues #7147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zzet
commented
Jun 18, 2014
- Issue may be not only in jira.
- Rewrite method for support different external issue trackers
lib/gitlab/markdown.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [85/80]
|
I'm not really sure why this fix is needed? Can you please explain what does this fix? |
|
@jvanbaarsen as you can see in config file gitlab support integration with different external issues trackers, not only JIRA. In our case it's Redmine. I don't think, that correct separate default |
|
@zzet Ok :-) I thought you meant that something was broken. Thanks for explaining! |
|
@jvanbaarsen no ;) only fix incorrect method name |
|
@zzet Can you please make this MR mergeable again? Thanks :) |
lib/gitlab/markdown.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation detected.
1. Issue may be not only in jira. 2. Rewrite method for support different external issue trackers
|
@jvanbaarsen done |
|
We are also unhappy, that from 6.9.0 release we can not have links to our redmine issues right from gitlab. |
|
@KSDaemon this PR resolve your problem. |
|
Yep. For now i've just patched our instance — works well. But this diff is outdated and require some modifications. |
|
Hmm... I don't know what happens, but it seems, that this doesn't work good. As i can see, it renders url not in all places. Sometimes it just ignore it. Even in the same project, same bugfix id, just different commits. |
|
@KSDaemon you can provide more accurate and detailed information, in order that I could see? |
lib/gitlab/markdown.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this line to
url = url_for_issue(identifier, project)or it showed no url in dashboard like this
<a class="gfm gfm-issue " href title="Issue in Redmine">33944</a>
blablabla
<a>|
@jvanbaarsen I'm on vacation from Monday. If you get any questions or concerns, I think that my colleague (@skv-headless) will help with this PR. |
|
@zzet What is the status of this PR? Are you still working on this? |
|
@jvanbaarsen I'll check @qqshfox feedback at Monday and report about PR. |
|
@zzet Ok thanks! 🍰 |
Fix mistake by @qqshfox report
|
@jvanbaarsen I have made changes in accordance with the remark. I think that's nothing more to do in this PR. |
|
Hi, I tested this patch and it works well so 👍 Could you fix a little gripe, the link_to("#{identifier}", url, options)to link_to("##{identifier}", url, options) |
Add missing '#'
|
@zzet Thank you! |
|
@bwrsandman Thank you 👍 |
|
This PR will be reviewed after 7.2 release which is due on the 22nd of August 2014. |
|
@jvanbaarsen @maxlazio @randx ping |
|
@maxlazio will look on it and merge if ok |
Update markdown reference to external issues
|
Thanks |
Update markdown reference to external issues Conflicts: lib/gitlab/markdown.rb