Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[minor-refactor] Add trailing newline to all text files. #7170
Present in the large majority of files of each respective type.
The only filetype for which we could be not sure is the
Bit me when doing
Refactoring command used:
@randx Uniformity implies lower costs. E.g.: can't do
bbastov's style says: "End each file with a newline."
Robocop seems to be enforcing this: https://github.com/bbatsov/rubocop/blob/master/config/default.yml#L407
But no big deal if rejected.
Refactor to follow style guides: yes or no? Refactor for DRYness / better organization yes or no?
Style refactors save time of future contributors, who will edit, try not to touch anything, then get barked at by hound CI or a human reviewer, and then have to change things.
I refactored the entire documentation at: #6863
This is particular issue is not important, but the policy is as it might prevent future contributors and reviewers from doing extra work. =)