Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add project stars. #7233
Fix ACCEPTING MR at http://feedback.gitlab.com/forums/176466-general/suggestions/4518904-star-a-project-to-show-it-at-the-top-of-your-dashb points 1. and 2.
Ignoring "Use nested module/class definitions instead of compact style." Hound warning as that style is used by all the rest of the API and recommended by Spinach itself. I propose we turn that warning off if possible.
Fixed RSpec failures which I caused due to driver incompatibilities... for some reason
https://travis-ci.org/gitlabhq/gitlabhq/jobs/29121023#L853 passed locally and is unrelated to this changed
https://travis-ci.org/gitlabhq/gitlabhq/jobs/29121026#L1182 happens on this PR, but passes locally. I don't understand why it is failing on Travis.
referenced this pull request
Jul 12, 2014
Can I add a
@cirosantilli At first I thought db index will be enough. But after looking at http://feedback.gitlab.com/forums/176466-general/suggestions/5647999-show-popular-project-on-the-public-projects-page I agree it makes sense to add
Also please make this PR mergeable. When ready to merge - please assign it to me. I will do review and merge if ok
All tests pass locally.
RSpec failures seem to be unrelated: https://travis-ci.org/gitlabhq/gitlabhq/jobs/29964656, and also happen on other merge requests like https://travis-ci.org/gitlabhq/gitlabhq/jobs/29956956
The Spinach failure https://travis-ci.org/gitlabhq/gitlabhq/jobs/29964450#L3085 was introduced by this and is consistent on Travis, but passes locally consistently. I am unable to understand why: it should be a simple click by anchor content. I have already searched a lot, and cannot understand why. If no one can explain it, I'll just remove that test (and move it to the model specs for instance).
@randx should be OK now: