New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Increase diff byte highlight contrast. #7340

Merged
merged 1 commit into from Jul 23, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Jul 21, 2014

Currently I have to concentrate too much to find the byte highlight in a line, specially the additions. This would make it easier to spot.

Before:

screenshot from 2014-07-21 12 26 13 gitlab diff highlight before

After:

screenshot from 2014-07-21 12 26 37 gitlab diff highlight after

Would be even more important if we decide to do: http://feedback.gitlab.com/forums/176466-general/suggestions/6191324-highlight-bytes-words-in-diffs-on-adjacent-multi

@TeatroIO

This comment has been minimized.

TeatroIO commented Jul 21, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Increase diff byte highlight contrast. to [UI] Increase diff byte highlight contrast. Jul 21, 2014

dzaporozhets added a commit that referenced this pull request Jul 23, 2014

Merge pull request #7340 from cirosantilli/diff-contrast
[UI] Increase diff byte highlight contrast.

@dzaporozhets dzaporozhets merged commit 136ff57 into gitlabhq:master Jul 23, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@cirosantilli cirosantilli deleted the cirosantilli:diff-contrast branch Jul 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment