New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to fixed SHA version on blob. #7472

Merged
merged 1 commit into from Sep 4, 2014

Conversation

6 participants
@cirosantilli
Contributor

cirosantilli commented Aug 11, 2014

@TeatroIO

This comment has been minimized.

TeatroIO commented Aug 11, 2014

I've prepared a stage. Click to open.

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Aug 11, 2014

@cirosantilli What about something like Permalink instead of Sha url?

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Aug 11, 2014

We could use that name as well. Summarizing the concept in few characters is challenging.

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Aug 11, 2014

Permalink will be ok

@cirosantilli cirosantilli changed the title from [WIP][Awaiting developper feedback] Add link to fixed SHA version on blob. to [WIP] Add link to fixed SHA version on blob. Aug 12, 2014

@@ -269,6 +269,10 @@ module SharedPaths
visit project_tree_path(@project, "6d39438")
end
step 'I visit project source page for "6d394385cf567f80a8fd85055db1ab4c5295806f"' do

This comment has been minimized.

@houndci-bot

houndci-bot Aug 12, 2014

Line is too long. [86/80]

@@ -269,6 +269,10 @@ module SharedPaths
visit project_tree_path(@project, "6d39438")
end
step 'I visit project source page for "6d394385cf567f80a8fd85055db1ab4c5295806f"' do
visit project_tree_path(@project, '6d394385cf567f80a8fd85055db1ab4c5295806f')

This comment has been minimized.

@houndci-bot

houndci-bot Aug 12, 2014

Line is too long. [81/80]

@cirosantilli cirosantilli changed the title from [WIP] Add link to fixed SHA version on blob. to Add link to fixed SHA version on blob. Aug 12, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Aug 13, 2014

The feature is ready I think the test failures are unrelated.

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Sep 1, 2014

@cirosantilli Can you please make mergeable again?

@cirosantilli cirosantilli force-pushed the cirosantilli:sha-link branch from bc20f6f to 81336bd Sep 1, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 1, 2014

Rebased (CHANGELOG conflict)

@dosire

This comment has been minimized.

Member

dosire commented Sep 4, 2014

@cirosantilli Awesome, thanks for this!

@randx merge?

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Sep 4, 2014

Nice!

@dzaporozhets dzaporozhets merged commit 81336bd into gitlabhq:master Sep 4, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@dosire

This comment has been minimized.

Member

dosire commented Sep 4, 2014

@cirosantilli Thanks again!

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 4, 2014

=)

@cirosantilli cirosantilli deleted the cirosantilli:sha-link branch Sep 4, 2014

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Nov 30, 2018

Merge branch '7472-epics-autocomplete' into 'master'
Support epics autocomplete for project objects

Closes gitlabhq#7472

See merge request gitlab-org/gitlab-ee!8180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment