New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default regex message to match regex. #7516

Merged
merged 1 commit into from Nov 5, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Aug 16, 2014

No description provided.

@TeatroIO

This comment has been minimized.

TeatroIO commented Aug 16, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:update-regex-msg branch from 68cb570 to 6bae8c4 Oct 1, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Oct 6, 2014

@randx looks good!

maxlazio added a commit that referenced this pull request Nov 5, 2014

Merge pull request #7516 from cirosantilli/update-regex-msg
Update default regex message to match regex.

@maxlazio maxlazio merged commit 42a1d80 into gitlabhq:master Nov 5, 2014

@cirosantilli cirosantilli deleted the cirosantilli:update-regex-msg branch Nov 5, 2014

@maxlazio

This comment has been minimized.

Member

maxlazio commented Nov 5, 2014

@cirosantilli this PR caused test failure. Fixed with d59f8ab

/cc @jvanbaarsen

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Nov 5, 2014

@maxlazio thanks for the heads up. Why didn't we notice it on the CI? Maybe because of: https://github.com/gitlabhq/gitlabhq/issues/8000 ?

We should solve the failure by DRYing the test up with the message otherwise it will break again later.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Nov 5, 2014

@maxlazio I have made a DRYer fix at: #8251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment