Skip to content

Conversation

@cirosantilli
Copy link
Contributor

No description provided.

@TeatroIO
Copy link

I've prepared a stage. Click to open.

@jvanbaarsen
Copy link
Contributor

@randx looks good!

maxlazio added a commit that referenced this pull request Nov 5, 2014
Update default regex message to match regex.
@maxlazio maxlazio merged commit 42a1d80 into gitlabhq:master Nov 5, 2014
@cirosantilli cirosantilli deleted the update-regex-msg branch November 5, 2014 10:50
@maxlazio
Copy link
Member

maxlazio commented Nov 5, 2014

@cirosantilli this PR caused test failure. Fixed with d59f8ab

/cc @jvanbaarsen

@cirosantilli
Copy link
Contributor Author

@maxlazio thanks for the heads up. Why didn't we notice it on the CI? Maybe because of: https://github.com/gitlabhq/gitlabhq/issues/8000 ?

We should solve the failure by DRYing the test up with the message otherwise it will break again later.

@cirosantilli
Copy link
Contributor Author

@maxlazio I have made a DRYer fix at: #8251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants