-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Checking browser version #7597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking browser version #7597
Conversation
|
I've prepared a stage. Click to open. |
|
@zzet Is there a possibility to hide that flash? |
|
@Razer6 At this moment - no. I can add close button, or auto-hide (better imho) if it need. |
|
Have there been issues with people using unsupported browsers and having issues? If there haven't been some strong cases I'm really not in favor of this. Lots of browsers other than the "officially" supported versions work for a lot of sites/apps. It drives me nuts when sites display this message to me but things work fine. Also, this is another list that developers have to keep up. |
|
@dblessing Scratch where it itches. I periodically enters feedback from users who use browsers from the list, the fact that something is not working or is not working properly. I'm tired of wasting time on debriefing. Of course, it is possible to reduce the requirements for browsers, and to expand the list. And also make the message concealed. |
|
I'm going to give this a 👎 @randx do you have an opinion on this? |
|
I am against white-listing browsers. GitLab can work fine in some unknown browsers based on webkit or so. Also it can works perfectly on older Chrome. I think this message only makes sense in cases like IE6-7 where its hardly usable. In this case blacklisting makes more sense. |
|
@randx sorry, but I'm hate blacklist-way. We have some requirements and this PR based on this doc. I'm added only minimum in browser list (we can add some another). I prefer more friendly rules, but if something not tested and can work wrong - mb better to say about it? What about old versions - I had some problems with old Firefox, Chrome, Chromium... After run this feature in production - users updated they browsers and no problem now. Of course - it is low-low-low priority feature :) And I'm not sure what you need it. We create it in our fork and send feature in main repo. Thx ) |
|
@zzet Thanks for your contribution. I'm closing this PR with it's current whitelist implementation. We might accept something for blacklisting IE6-7 browsers as Dmitriy noted. |
|
@zzet, I'm considering submitting a PR based on your own code, but implementing a blacklist, as requested |
|
@vicvega no problem :) |
The code checks whether the user's browser to the list of supported. Are listed on the page: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/install/requirements.md#supported-webbrowsers. If the browser is outdated or unsupported - displays information block.
All rules are described in config file: config/initializers/browser_modern_rules.rb