New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove HAML eval for const strings. #7609

Merged
merged 1 commit into from Aug 28, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Aug 26, 2014

  • faster
  • equally readable

Found with: git grep '^\s*\= "' | grep -v '#{'

@TeatroIO

This comment has been minimized.

TeatroIO commented Aug 26, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-haml-strings branch from 1f7f2bc to 15c8967 Aug 26, 2014

@cirosantilli cirosantilli changed the title from Remove unnecessary Ruby eval for const strings. to Remove HAML eval for const strings. Aug 26, 2014

@cirosantilli cirosantilli changed the title from Remove HAML eval for const strings. to [refactor] Remove HAML eval for const strings. Aug 26, 2014

dzaporozhets added a commit that referenced this pull request Aug 28, 2014

Merge pull request #7609 from cirosantilli/rm-haml-strings
[refactor] Remove HAML eval for const strings.

@dzaporozhets dzaporozhets merged commit ef4848a into gitlabhq:master Aug 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-haml-strings branch Aug 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment