Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing to on reassign Merge Request email to unassigned. #7661

Merged
merged 1 commit into from Sep 4, 2014

Conversation

4 participants
@cirosantilli
Copy link
Contributor

commented Sep 1, 2014

Factors out MR and issue email.

Before this, when you reassign to unassigned, it said on the email "reassigned to " (empty).

Now it says: "reassigned to unassigned", just like it does for issues.

This started out as a refactor but ended on a bug fix: it had already been fixed for issues at cirosantilli@39f82b7 but not for MRs because of duplication.

Found using https://github.com/UncleGene/flay-haml

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 1, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title Fix missing to on reassign email when unassigned. Fix missing to on reassign MR email to unassigned. Sep 1, 2014

Fix missing to on reassign MR email to unassigned.
Factors out MR and issue email.

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-issue-mr-email branch from 9210f05 to 330251d Sep 1, 2014

@cirosantilli cirosantilli changed the title Fix missing to on reassign MR email to unassigned. Fix missing to on reassign Merge Request email to unassigned. Sep 2, 2014

@Razer6

This comment has been minimized.

Copy link
Member

commented Sep 3, 2014

@randx Looks good!

dzaporozhets added a commit that referenced this pull request Sep 4, 2014

Merge pull request #7661 from cirosantilli/factor-issue-mr-email
Fix missing to on reassign Merge Request email to unassigned.

@dzaporozhets dzaporozhets merged commit 640a3c5 into gitlabhq:master Sep 4, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@cirosantilli cirosantilli deleted the cirosantilli:factor-issue-mr-email branch Sep 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.