Factor new issue and edit MR forms. #7678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of code duplication here.
There is also a third copy which has diverged more and which we should DRY out as well: the new MR form. It probably has the best visual style of the three and should be the one to copy. Opened an issue for that at: https://github.com/gitlabhq/gitlabhq/issues/7679 so we won't forget.
The issue edit and new were already factored.
Minor visible changes:
I cannot see any other behavior / UI changes.
Non-visible changes:
input type="text"."pad"from the merge request form. Not used anywhere in the app.TODO in future merge requests: DRY those forms even further on the points they diverged more:
Found using https://github.com/UncleGene/flay-haml