Skip to content

Conversation

@bbodenmiller
Copy link
Contributor

Addresses changes made to installation guide and config files but never applied in update process. Relevant changes to installation guide and config files were made in cbb5b00, 498a4e6, c33d5e1, 485162e#diff-e1059d0fa0437ffad94facff86210603, 72e2fe2#diff-d1b4ff7de834bae6008dd49550413a6f, 5163a8f#diff-e1059d0fa0437ffad94facff86210603, 993af5d#diff-e1059d0fa0437ffad94facff86210603, & d3f5a0c.

Doesn't make sense to add this to old install guides as most users have already passed those install guides and this doesn't address specific issues they would have encountered during upgrading.

Main purpose of these instructions are to get old installations more up to speed with latest recommended setup as per installation.md and database_mysql.md.

@TeatroIO
Copy link

I've prepared a stage. Click to open.

@dosire
Copy link
Member

dosire commented Sep 12, 2014

Thanks for writing it, I love it.

@dosire
Copy link
Member

dosire commented Sep 16, 2014

@bbodenmiller I discussed this with the team, we more clearly want to mark this optional so people who recently started using GitLab are not scared by it. Some suggestions:

  1. Change header from 'Cleanup MySQL database' => 'Optional optimizations on MySQL databases that where created before GitLab 5.0'
  2. It will probably be hard, but can we give a bit more background on each item which version of GitLab it was solved and when people don't need to worry about it?

@dosire
Copy link
Member

dosire commented Sep 16, 2014

/cc @randx

@bbodenmiller
Copy link
Contributor Author

Will try to work on this soon. When do you need to make sure it makes 7.3 RC releases?

@dosire
Copy link
Member

dosire commented Sep 16, 2014

@bbodenmiller I'm not sure.

@dosire
Copy link
Member

dosire commented Sep 19, 2014

This was too late for 7.3, please target 7.4

Do we need to address UTF8 too? https://groups.google.com/d/msgid/gitlabhq/880C99DE-1362-4E3D-AA98-9F5D256BC027%40gmail.com

@Razer6 Razer6 added this to the 7.4 milestone Sep 19, 2014
@bbodenmiller
Copy link
Contributor Author

I'm unsure how to address the UTF8 issue. As far as I can tell GitLab has always instructed user to install with UTF8. Earliest commit I found about creating MySQL DB is da77cd2:

CREATE DATABASE IF NOT EXISTS `gitlabhq_production` DEFAULT CHARACTER SET `utf8` COLLATE `utf8_unicode_ci`;

Perhaps d3f5a0c from #7317 fixed the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in cbb5b00

@bbodenmiller
Copy link
Contributor Author

@dosire believe I have address all of the feedback.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only applies if running MySQL database.
=>
Only applies if running MySQL database created with GitLab 6.7 or earlier.

@dosire
Copy link
Member

dosire commented Oct 12, 2014

@bbodenmiller I've left one line comment, to ensure people that started running GitLab recently understand they are not affected.

@bbodenmiller
Copy link
Contributor Author

Updated. In the future I recommend database configuration changes are not accepted unless accompanied by migration details in upgrade guide.

Addresses changes made to installation guide and config files but never
applied in update process. Relevant changes to installation guide and
config files were made in
gitlabhq/gitlabhq@cbb5b00,
gitlabhq/gitlabhq@498a4e6,
gitlabhq/gitlabhq@c33d5e1,
gitlabhq/gitlabhq@485162e#diff-e1059d0fa0437ffad94facff86210603,
gitlabhq/gitlabhq@72e2fe2#diff-d1b4ff7de834bae6008dd49550413a6f,
gitlabhq/gitlabhq@5163a8f#diff-e1059d0fa0437ffad94facff86210603,
gitlabhq/gitlabhq@993af5d#diff-e1059d0fa0437ffad94facff86210603,
&
gitlabhq/gitlabhq@d3f5a0c.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider changing: take => make
(please send pull request)

dosire added a commit that referenced this pull request Oct 13, 2014
@dosire dosire merged commit f7b1902 into gitlabhq:master Oct 13, 2014
@dosire
Copy link
Member

dosire commented Oct 13, 2014

Thanks @bbodenmiller

@dosire
Copy link
Member

dosire commented Oct 13, 2014

@bbodenmiller And I agree that config changes should be in the upgrade guide.

@matthewdfleming
Copy link

We noticed one issue with the merge_request_diffs table. For some reason it was not set up as a UTF8 capable table. Not sure why that would be the case, but the solution was to just switch the character set. Now UTF8 commits/merge requests works properly.

@bbodenmiller
Copy link
Contributor Author

@matthewdfleming can you give the commands you used to change the character set?

@matthewdfleming
Copy link

ALTER TABLE merge_request_diffs 
  CONVERT TO CHARACTER SET utf8 
  COLLATE utf8_unicode_ci;

@bbodenmiller
Copy link
Contributor Author

@dosire what do you think, should we have users convert tables to make sure they are set to correct character set?

@dosire
Copy link
Member

dosire commented Oct 14, 2014

@bbodenmiller Yes, if not in there consider adding it to your MySQL upgrade text.

bbodenmiller added a commit to bbodenmiller/gitlabhq that referenced this pull request Oct 14, 2014
As discussed at gitlabhq#7742 (comment) make sure that tables have correct char set.
@bbodenmiller
Copy link
Contributor Author

Done, see #8041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants