-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Cleanup MySQL database #7742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup MySQL database #7742
Conversation
|
I've prepared a stage. Click to open. |
|
Thanks for writing it, I love it. |
|
@bbodenmiller I discussed this with the team, we more clearly want to mark this optional so people who recently started using GitLab are not scared by it. Some suggestions:
|
|
/cc @randx |
|
Will try to work on this soon. When do you need to make sure it makes 7.3 RC releases? |
|
@bbodenmiller I'm not sure. |
|
This was too late for 7.3, please target 7.4 Do we need to address UTF8 too? https://groups.google.com/d/msgid/gitlabhq/880C99DE-1362-4E3D-AA98-9F5D256BC027%40gmail.com |
|
I'm unsure how to address the UTF8 issue. As far as I can tell GitLab has always instructed user to install with UTF8. Earliest commit I found about creating MySQL DB is da77cd2: |
doc/update/7.3-to-7.4.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in cbb5b00
|
@dosire believe I have address all of the feedback. |
doc/update/7.3-to-7.4.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only applies if running MySQL database.
=>
Only applies if running MySQL database created with GitLab 6.7 or earlier.
|
@bbodenmiller I've left one line comment, to ensure people that started running GitLab recently understand they are not affected. |
|
Updated. In the future I recommend database configuration changes are not accepted unless accompanied by migration details in upgrade guide. |
Addresses changes made to installation guide and config files but never applied in update process. Relevant changes to installation guide and config files were made in gitlabhq/gitlabhq@cbb5b00, gitlabhq/gitlabhq@498a4e6, gitlabhq/gitlabhq@c33d5e1, gitlabhq/gitlabhq@485162e#diff-e1059d0fa0437ffad94facff86210603, gitlabhq/gitlabhq@72e2fe2#diff-d1b4ff7de834bae6008dd49550413a6f, gitlabhq/gitlabhq@5163a8f#diff-e1059d0fa0437ffad94facff86210603, gitlabhq/gitlabhq@993af5d#diff-e1059d0fa0437ffad94facff86210603, & gitlabhq/gitlabhq@d3f5a0c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider changing: take => make
(please send pull request)
|
Thanks @bbodenmiller |
|
@bbodenmiller And I agree that config changes should be in the upgrade guide. |
|
We noticed one issue with the merge_request_diffs table. For some reason it was not set up as a UTF8 capable table. Not sure why that would be the case, but the solution was to just switch the character set. Now UTF8 commits/merge requests works properly. |
|
@matthewdfleming can you give the commands you used to change the character set? |
|
|
@dosire what do you think, should we have users convert tables to make sure they are set to correct character set? |
|
@bbodenmiller Yes, if not in there consider adding it to your MySQL upgrade text. |
As discussed at gitlabhq#7742 (comment) make sure that tables have correct char set.
|
Done, see #8041. |
Addresses changes made to installation guide and config files but never applied in update process. Relevant changes to installation guide and config files were made in cbb5b00, 498a4e6, c33d5e1, 485162e#diff-e1059d0fa0437ffad94facff86210603, 72e2fe2#diff-d1b4ff7de834bae6008dd49550413a6f, 5163a8f#diff-e1059d0fa0437ffad94facff86210603, 993af5d#diff-e1059d0fa0437ffad94facff86210603, & d3f5a0c.
Doesn't make sense to add this to old install guides as most users have already passed those install guides and this doesn't address specific issues they would have encountered during upgrading.
Main purpose of these instructions are to get old installations more up to speed with latest recommended setup as per installation.md and database_mysql.md.