Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Set textarea resize:vertical by default. #7772

Merged
merged 1 commit into from Sep 22, 2014

Conversation

4 participants
@cirosantilli
Copy link
Contributor

commented Sep 19, 2014

Horizontal resize breaks every textarea in of the UI should never be allowed.

Also, it is hard for users to resize vertically without resizing horizontally, so they are likely to do it by mistake.

This change intends to affect every textarea of the app.

This is an extension of: #7483

Sample breaks:

With a float right as in milestone:

screenshot from 2014-09-19 08 59 38 gitlab text resize milestone

If you stretch the textarea horizontally and then shrink the browser window, it does not resize and falls out:

screenshot from 2014-09-19 09 00 54 gitlab textarea resize comment out of window

And in general, it is ugly having the textarea not align with the rest of the UI:

screenshot from 2014-09-19 09 01 33 gitlab textarea resize issue small

Burninate!

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 19, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title Set textarea resize:vertical by default. [UI] Set textarea resize:vertical by default. Sep 19, 2014

@@ -1,3 +1,7 @@
textarea {
resize: vertical;

This comment has been minimized.

Copy link
@Razer6

Razer6 Sep 19, 2014

Member

Could you make a 2-char indentation?

This comment has been minimized.

Copy link
@cirosantilli

cirosantilli Sep 19, 2014

Author Contributor

Done.

@cirosantilli cirosantilli force-pushed the cirosantilli:resize-vertical branch from 07f163b to 0576c02 Sep 19, 2014

@Razer6 Razer6 added this to the 7.4 milestone Sep 20, 2014

dzaporozhets added a commit that referenced this pull request Sep 22, 2014

Merge pull request #7772 from cirosantilli/resize-vertical
[UI] Set textarea resize:vertical by default.

@dzaporozhets dzaporozhets merged commit 248990b into gitlabhq:master Sep 22, 2014

1 check passed

default The build passed on Semaphore.
Details
@dzaporozhets

This comment has been minimized.

Copy link
Member

commented Sep 22, 2014

thank you

@cirosantilli cirosantilli deleted the cirosantilli:resize-vertical branch Sep 22, 2014

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Jan 3, 2019

Merge branch '7772-add-subscription-table-to-gitlab-com-billing-areas…
…' into 'master'

Resolve "Add subscription table to GitLab.com billing areas"

Closes gitlabhq#7772

See merge request gitlab-org/gitlab-ee!7885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.