New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link_to_reply_diff. #7792

Merged
merged 1 commit into from Sep 22, 2014

Conversation

5 participants
@cirosantilli
Contributor

cirosantilli commented Sep 19, 2014

Came from a typo < instead of <<.

@randx consider using https://github.com/scrooloose/syntastic and gem install ruby-lint: it put a huge yellow marker next to that line saying statement without effect. (does some false positives too, but I think it's worth it).

Before:

screenshot from 2014-09-19 14 06 51 gitlab reply diff before

After:

screenshot from 2014-09-19 14 06 32 gitlab reply diff

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 19, 2014

I've prepared a stage. Click to open.

link_text << "Reply"
end
link_text = content_tag(:i, nil, class: 'icon-comment')
link_text << " Reply"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 19, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@cirosantilli cirosantilli force-pushed the cirosantilli:link_to_reply_diff branch from af43910 to 9439602 Sep 19, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Sep 19, 2014

@randx Looks good!

@Razer6 Razer6 added this to the 7.4 milestone Sep 19, 2014

dzaporozhets added a commit that referenced this pull request Sep 22, 2014

@dzaporozhets dzaporozhets merged commit 6a1323f into gitlabhq:master Sep 22, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:link_to_reply_diff branch Sep 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment