Skip to content

Conversation

@cirosantilli
Copy link
Contributor

Behavior improvements:

  • middle click on the button does not open a javascript:; tab
  • on hover browser does not show the link destination javascript:;

Appearance changes: none.

Also more semantic: links exist to redirect your browser somewhere else. This explains the better behavior.

Works because button.btn type="button" and a.btn are styled almost exactly the same in Bootstrap.

Just for reference, the elements that are affected are the "Reply" button and the "+" on diff comments:

screenshot from 2014-09-19 15 24 22 gitlab javascript button to

@TeatroIO
Copy link

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title [factor] Replace javascript:; links with buttons. Replace javascript:; links with buttons. Sep 19, 2014
@cirosantilli cirosantilli force-pushed the replace-javascript branch 3 times, most recently from db1fe05 to bc97259 Compare September 19, 2014 16:14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surrounding space missing in default value assignment.

@Razer6
Copy link
Member

Razer6 commented Sep 19, 2014

@randx Looks good!

@Razer6 Razer6 added this to the 7.4 milestone Sep 19, 2014
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cirosantilli why this spaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@randx I think Hound requires it saying that we must align the hash keys. I will try without to make sure.

@cirosantilli cirosantilli force-pushed the replace-javascript branch 2 times, most recently from c64ded1 to c4fdf75 Compare September 22, 2014 18:58
@cirosantilli
Copy link
Contributor Author

Failure appears unrelated and not reproduced locally.

dzaporozhets added a commit that referenced this pull request Sep 23, 2014
Replace javascript:; links with buttons.
@dzaporozhets dzaporozhets merged commit 6e328d5 into gitlabhq:master Sep 23, 2014
@cirosantilli cirosantilli deleted the replace-javascript branch September 23, 2014 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants