New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor zen mode. #7801

Merged
merged 1 commit into from Sep 20, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Sep 20, 2014

Almost the same code was on 3 different places.

Minor UI change: both new issue and merge request description textarea are now the same size. They were different sizes, so I picked an intermediate new size. The change is almost unnoticeable.

The pages that could be affected are: new / edit issue and merge request, diff notes and comments.

This continues the move for form DRYness as in #7678

cc. @Razer6 if you get the time please check that I didn't break the feature =) A good indicator of non-DRYness are strings shown on the UI: when I saw that there were two occurrences of "Edit in fullscreen", I immediately git grep -C2 'Edit in and found this opportunity for DRYing.

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 20, 2014

I've prepared a stage. Click to open.

@Razer6

This comment has been minimized.

Member

Razer6 commented Sep 20, 2014

I'll test the PR as soon I've my dev setup working again. HDD crash 👊

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 20, 2014

Ouch 🏥

@Razer6

This comment has been minimized.

Member

Razer6 commented Sep 20, 2014

I checked out the PR locally and tested it. Looks good 👍 Since this is directly related to a new introduced feature in 7.3 I merge this.

Razer6 added a commit that referenced this pull request Sep 20, 2014

@Razer6 Razer6 merged commit 8fd0d74 into gitlabhq:master Sep 20, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:dry-zen-view branch Sep 20, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Sep 20, 2014

@cirosantilli Hey, I just saw an minor issue for the Edit in Fullscreen label. This is not related to this PR. If the text area for a not has focus (blue glow), hovering over Edit in Fullscreen overwrites the glow.

screenshot 2014-09-20 18 10 26

I tried to fix this, but do not see the error. Only the opacity is changed when hovering. Maybe you have a glue?

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 20, 2014

Hmm I haven't been able to reproduce on Firefox 32 Chromium 37. What view and browser are you on?

@Razer6

This comment has been minimized.

Member

Razer6 commented Sep 20, 2014

Hmm, Chrome 37.0.2062.122 on OSX also doesn't show this issue. I'm on Safari 7.1 on OSX 10.9.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment