New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ununsed CONTRIBUTING link on edit MR form. #7803

Merged
merged 1 commit into from Sep 25, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Sep 20, 2014

The code is never reached because the new and edit MR forms have diverged,
and the CONTRIBUTING link is not shown when editing MRs (because of the !@merge_request.persisted?).

Dead code 馃拃

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 20, 2014

I've prepared a stage. Click to open.

@Razer6 Razer6 added this to the 7.4 milestone Sep 21, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Sep 22, 2014

@cirosantilli Can you rebase?

Remove ununsed CONTRIBUTING link on edit MR form.
The code is never reached because the new and edit MR forms have diverged,
and the CONTRIBUTING link is not shown when editing MRs.

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-unused-mr-contributing branch from afac76d to 83e8f92 Sep 22, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 22, 2014

Rebased.

dzaporozhets added a commit that referenced this pull request Sep 25, 2014

Merge pull request #7803 from cirosantilli/rm-unused-mr-contributing
Remove ununsed CONTRIBUTING link on edit MR form.

@dzaporozhets dzaporozhets merged commit ae94f59 into gitlabhq:master Sep 25, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-unused-mr-contributing branch Sep 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment