Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor issue and MR edit form error list. #7804

Merged

Conversation

4 participants
@cirosantilli
Copy link
Contributor

commented Sep 20, 2014

Direct continuation to #7678

This one factors the error messages.

Note: I am unable to view the error messages, because the only thing that could generate an error, an empty title, is not allowed by the browser because of the "required: true", so I could not test it the CSS looks good.

If anyone knows of a way to do this test, please tell me.

In any case, that is basically dead code, and now it is factored dead code.

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 20, 2014

I've prepared a stage. Click to open.

@Razer6

This comment has been minimized.

Copy link
Member

commented Sep 21, 2014

@randx Looks good!

@Razer6 Razer6 added this to the 7.4 milestone Sep 21, 2014

dzaporozhets added a commit that referenced this pull request Sep 22, 2014

Merge pull request #7804 from cirosantilli/factor-issue-mr-form-error
Factor issue and MR edit form error list.

@dzaporozhets dzaporozhets merged commit f96b954 into gitlabhq:master Sep 22, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:factor-issue-mr-form-error branch Sep 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.