Factor error and success methods from services. #7807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important factorization here is to fix a single
status: :errorandstatus: :sucesskeys for all services.The
DeleteBranchservice had already started diverging as is used the key:stateinstead of:status.For the error, it was also possible to factor out the
messageas it is used on all returns. The same was not possible forsuccess.The initialize signature was modified in order to allow to use inheritance. This also makes the execute function parameters lists shorter since
projectandcurrent_usernow go on the initializer like all other services.The next step would be to have an uniform error reporting across all services: some create services currently return the created object with errors added by
.errors.add. Maybe we should just follow that for all services as it is cleaner than playing with hashes.