New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test line without effect because no should. #7834

Merged
merged 1 commit into from Oct 3, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Sep 23, 2014

I think the should == was forgotten, as the return value is never used, and the function is only used in intermediate steps, not on the conclusions.

If I add the should, tests start to fail. Not sure if Poltergeist can handle window.location stuff.

Even if it could, tests should still fail, because when you edit the issue search all possible parameters get added to the URL, not just the issue_search.

So let's just remove this.

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 23, 2014

I've prepared a stage. Click to open.

Razer6 added a commit that referenced this pull request Oct 3, 2014

Merge pull request #7834 from cirosantilli/rm-empty-eq
Remove test line without effect because no should.

@Razer6 Razer6 merged commit 6f797f8 into gitlabhq:master Oct 3, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-empty-eq branch Oct 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment