New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate -> execute_script when return not needed. #7838

Merged
merged 1 commit into from Sep 24, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Sep 24, 2014

execute does not fetch the return value. It is therefore faster and should be used when the return is not needed.

The two other occurrences on the page were factored out in #7837

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 24, 2014

I've prepared a stage. Click to open.

Razer6 added a commit that referenced this pull request Sep 24, 2014

Merge pull request #7838 from cirosantilli/evaluate-exec
evaluate -> execute_script when return not needed.

@Razer6 Razer6 merged commit b794fdb into gitlabhq:master Sep 24, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:evaluate-exec branch Sep 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment