Skip to content

Conversation

@cirosantilli
Copy link
Contributor

These bugs were introduced by myself at #7807

The fact that the refactoring lead to bugs means we should add more tests for those error cases =)

Also removed the out[:error] = '' which never happens: every place of the app first checks for success.

Added tests that would have prevented me from generating this bug.

Needs to be double checked

One of the tests is @wip as explained on the source: I can't get it working no matter what. Still it shows the behavior and does an initial step to point to the cause of the problem.

This seems to be an unrelated bug in GitLab, so I've opened a separate report at: https://github.com/gitlabhq/gitlabhq/issues/7950

Update

This was partially fixed after this PR at: 184e0f , but only partially since the blob destroy, edit and API messages were not fixed, only the new blob case.

@TeatroIO
Copy link

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title Use :message key, not :error for File::Service. Fix missing flash on file edit error from web UI. Sep 29, 2014
@cirosantilli cirosantilli force-pushed the error-to-msg branch 2 times, most recently from 1af0c64 to d7082ac Compare October 1, 2014 09:10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

@cirosantilli cirosantilli changed the title Fix missing flash on file edit error from web UI. [WIP] Fix missing flash on file edit error from web UI. Oct 3, 2014
@cirosantilli cirosantilli changed the title [WIP] Fix missing flash on file edit error from web UI. Fix missing flash on file edit error from web UI. Oct 7, 2014
@Razer6
Copy link
Member

Razer6 commented Oct 13, 2014

@cirosantilli Could you rebase?

@Razer6 Razer6 added this to the 7.4 milestone Oct 13, 2014
@cirosantilli cirosantilli changed the title Fix missing flash on file edit error from web UI. [WIP] Fix missing flash on file edit error from web UI. Oct 13, 2014
@cirosantilli cirosantilli changed the title [WIP] Fix missing flash on file edit error from web UI. Fix missing flash on file edit error from web UI. Oct 13, 2014
@cirosantilli
Copy link
Contributor Author

@Razer6 done.

@Razer6
Copy link
Member

Razer6 commented Oct 18, 2014

@randx @maxlazio This PR should still go to 7.4, because it's fixing a regression introduced in this release.

@cirosantilli
Copy link
Contributor Author

This was partially fixed at: 184e0f , but only partially since the blob edit, destroy and API messages were not fixed.

@dosire
Copy link
Member

dosire commented Oct 19, 2014

@cirosantilli Thanks for adding regression tests Ciro!

@cirosantilli
Copy link
Contributor Author

I want this baby to work! 😉

dzaporozhets added a commit that referenced this pull request Oct 20, 2014
Fix missing flash on file edit error from web UI.
@dzaporozhets dzaporozhets merged commit d4bc125 into gitlabhq:master Oct 20, 2014
@dzaporozhets
Copy link
Contributor

Thanks!

@dzaporozhets dzaporozhets modified the milestones: 7.4, 7.5 Oct 20, 2014
@cirosantilli cirosantilli deleted the error-to-msg branch October 20, 2014 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants