-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix missing flash on file edit error from web UI. #7856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've prepared a stage. Click to open. |
1af0c64 to
d7082ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
|
@cirosantilli Could you rebase? |
d7082ac to
2d23522
Compare
|
@Razer6 done. |
|
This was partially fixed at: 184e0f , but only partially since the blob edit, destroy and API messages were not fixed. |
|
@cirosantilli Thanks for adding regression tests Ciro! |
|
I want this baby to work! 😉 |
Fix missing flash on file edit error from web UI.
|
Thanks! |
These bugs were introduced by myself at #7807
The fact that the refactoring lead to bugs means we should add more tests for those error cases =)
Also removed the
out[:error] = ''which never happens: every place of the app first checks forsuccess.Added tests that would have prevented me from generating this bug.
Needs to be double checked
One of the tests is
@wipas explained on the source: I can't get it working no matter what. Still it shows the behavior and does an initial step to point to the cause of the problem.This seems to be an unrelated bug in GitLab, so I've opened a separate report at: https://github.com/gitlabhq/gitlabhq/issues/7950
Update
This was partially fixed after this PR at: 184e0f , but only partially since the blob destroy, edit and API messages were not fixed, only the new blob case.