Skip to content

Conversation

@cirosantilli
Copy link
Contributor

find . -iname '*.rb' | xargs perl -lapi -e 's/\bdef ([^ (]+)[ ]+([^(].*)/def $1($2)/'

@TeatroIO
Copy link

I've prepared a stage. Click to open.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused method argument - resource. If it's necessary, use _ or _resource as an argument name to indicate that it won't be used. You can also write as after_sign_up_path_for(*) if you want the method to accept any arguments but don't care about them.

@Razer6
Copy link
Member

Razer6 commented Sep 25, 2014

@cirosantilli Should we also state this in the contributing guide?

@cirosantilli
Copy link
Contributor Author

I think not: it's already on the style guide we follow and hound should bark.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename is_default_branch? to default_branch?.

@Razer6
Copy link
Member

Razer6 commented Oct 3, 2014

@cirosantilli Can you rebase to make it mergable?

@Razer6 Razer6 added this to the 7.4 milestone Oct 3, 2014
@cirosantilli
Copy link
Contributor Author

Done!

Razer6 added a commit that referenced this pull request Oct 3, 2014
Add parenthesis to function def with arguments.
@Razer6 Razer6 merged commit 9f45e22 into gitlabhq:master Oct 3, 2014
@cirosantilli cirosantilli deleted the def-param-paren branch October 3, 2014 08:09
tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Nov 6, 2018
…s' into 'master'

Geo: Stale docs on frequency of Geo replication

Closes gitlabhq#7858

See merge request gitlab-org/gitlab-ee!8061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants