-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add parenthesis to function def with arguments. #7858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cirosantilli
commented
Sep 25, 2014
|
I've prepared a stage. Click to open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused method argument - resource. If it's necessary, use _ or _resource as an argument name to indicate that it won't be used. You can also write as after_sign_up_path_for(*) if you want the method to accept any arguments but don't care about them.
|
@cirosantilli Should we also state this in the contributing guide? |
|
I think not: it's already on the style guide we follow and hound should bark. |
675577c to
db36645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename is_default_branch? to default_branch?.
db36645 to
6ec9e68
Compare
|
@cirosantilli Can you rebase to make it mergable? |
6ec9e68 to
2e9f5de
Compare
|
Done! |
Add parenthesis to function def with arguments.
…s' into 'master' Geo: Stale docs on frequency of Geo replication Closes gitlabhq#7858 See merge request gitlab-org/gitlab-ee!8061