New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web UI file CRUD tests. #7862

Merged
merged 1 commit into from Sep 29, 2014

Conversation

5 participants
@cirosantilli
Contributor

cirosantilli commented Sep 26, 2014

This PR adds the first file modification operations (create, edit and delete).

They were currently undertested, and this has already lead me to not notice bugs during refactoring at: #7856

This is probably the case because the ability to edit repositories on tests was only recently added.

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 26, 2014

I've prepared a stage. Click to open.

@@ -16,12 +16,24 @@ class Spinach::Features::ProjectBrowseFiles < Spinach::FeatureSteps
page.should have_content "LICENSE"
end
step 'I see the ".gitignore"' do
page.should have_content ".gitignore"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 26, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

end
step 'I don\'t see the ".gitignore"' do
page.should_not have_content ".gitignore"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 26, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

Add web UI file CRUD tests.
me/ciro/bak/git/cirosantilli.com/web'

@cirosantilli cirosantilli force-pushed the cirosantilli:test-change-file branch from bf96d91 to f456fce Sep 26, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 26, 2014

Failures unrelated.

@Razer6 Razer6 added this to the 7.4 milestone Sep 27, 2014

dzaporozhets added a commit that referenced this pull request Sep 29, 2014

@dzaporozhets dzaporozhets merged commit 8163a43 into gitlabhq:master Sep 29, 2014

1 check failed

default The build failed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:test-change-file branch Sep 29, 2014

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Nov 6, 2018

Merge branch 'feature-flags-mvc-docs' into 'master'
Add documentation for Feature Flags

Closes gitlabhq#7862

See merge request gitlab-org/gitlab-ee!7818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment