Skip to content

Conversation

@cirosantilli
Copy link
Contributor

The advantages of this are the same as of the merged #7793.

For example, middle clicking on the link would open a new tab without the modal since it is Javascript based.

@TeatroIO
Copy link

I've prepared a stage. Click to open.

@cirosantilli
Copy link
Contributor Author

Failures unrelated.

@Razer6 Razer6 added this to the 7.4 milestone Sep 27, 2014
@Razer6
Copy link
Member

Razer6 commented Sep 27, 2014

It seems adding a label retriggers semaphore.

@cirosantilli
Copy link
Contributor Author

Interesting! Could not find it documented, but it does appear to be the case.

@Razer6
Copy link
Member

Razer6 commented Sep 27, 2014

For milestones it's not the case. I tried the order. I asked semaphore here: https://twitter.com/Razer6/status/515796862331551744

@dblessing
Copy link
Member

@cirosantilli Can you please make this mergeable?

@cirosantilli cirosantilli force-pushed the rm-blob-link-to-button branch from 7f2d916 to 0e0b6be Compare October 24, 2014 19:11
@cirosantilli cirosantilli changed the title Transform remove blob link into button. [WIP] Transform remove blob link into button. Oct 24, 2014
@cirosantilli cirosantilli force-pushed the rm-blob-link-to-button branch from 0e0b6be to e491224 Compare October 24, 2014 21:44
@cirosantilli cirosantilli changed the title [WIP] Transform remove blob link into button. Transform remove blob link into button. Oct 25, 2014
@cirosantilli
Copy link
Contributor Author

Updated.

@vsizov
Copy link
Contributor

vsizov commented Nov 5, 2014

thank you @cirosantilli

vsizov added a commit that referenced this pull request Nov 5, 2014
Transform remove blob link into button.
@vsizov vsizov merged commit f847728 into gitlabhq:master Nov 5, 2014
@cirosantilli cirosantilli deleted the rm-blob-link-to-button branch November 5, 2014 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants