Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform remove blob link into button. #7863

Merged
merged 1 commit into from Nov 5, 2014

Conversation

6 participants
@cirosantilli
Copy link
Contributor

commented Sep 26, 2014

The advantages of this are the same as of the merged #7793.

For example, middle clicking on the link would open a new tab without the modal since it is Javascript based.

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 26, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-blob-link-to-button branch from f0ddc9e to 7f2d916 Sep 26, 2014

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2014

Failures unrelated.

@Razer6 Razer6 added this to the 7.4 milestone Sep 27, 2014

@Razer6

This comment has been minimized.

Copy link
Member

commented Sep 27, 2014

It seems adding a label retriggers semaphore.

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2014

Interesting! Could not find it documented, but it does appear to be the case.

@Razer6

This comment has been minimized.

Copy link
Member

commented Sep 27, 2014

For milestones it's not the case. I tried the order. I asked semaphore here: https://twitter.com/Razer6/status/515796862331551744

@dblessing

This comment has been minimized.

Copy link
Member

commented Oct 24, 2014

@cirosantilli Can you please make this mergeable?

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-blob-link-to-button branch from 7f2d916 to 0e0b6be Oct 24, 2014

@cirosantilli cirosantilli changed the title Transform remove blob link into button. [WIP] Transform remove blob link into button. Oct 24, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-blob-link-to-button branch from 0e0b6be to e491224 Oct 24, 2014

@cirosantilli cirosantilli changed the title [WIP] Transform remove blob link into button. Transform remove blob link into button. Oct 25, 2014

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2014

Updated.

@vsizov

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2014

thank you @cirosantilli

vsizov added a commit that referenced this pull request Nov 5, 2014

Merge pull request #7863 from cirosantilli/rm-blob-link-to-button
Transform remove blob link into button.

@vsizov vsizov merged commit f847728 into gitlabhq:master Nov 5, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-blob-link-to-button branch Nov 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.