-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Transform remove blob link into button. #7863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've prepared a stage. Click to open. |
f0ddc9e to
7f2d916
Compare
Contributor
Author
|
Failures unrelated. |
Member
|
It seems adding a label retriggers semaphore. |
Contributor
Author
|
Interesting! Could not find it documented, but it does appear to be the case. |
Member
|
For milestones it's not the case. I tried the order. I asked semaphore here: https://twitter.com/Razer6/status/515796862331551744 |
Member
|
@cirosantilli Can you please make this mergeable? |
7f2d916 to
0e0b6be
Compare
0e0b6be to
e491224
Compare
Contributor
Author
|
Updated. |
Contributor
|
thank you @cirosantilli |
vsizov
added a commit
that referenced
this pull request
Nov 5, 2014
Transform remove blob link into button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantages of this are the same as of the merged #7793.
For example, middle clicking on the link would open a new tab without the modal since it is Javascript based.