New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type submit from button_tag since default. #7864

Merged
merged 1 commit into from Sep 27, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Sep 26, 2014

The generated HTML is unchanged, becomes uniform with other button_tag usages.

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 26, 2014

I've prepared a stage. Click to open.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 26, 2014

Failures unrelated.

@Razer6

This comment has been minimized.

Member

Razer6 commented Sep 27, 2014

Documented here. Ready to go.

@Razer6 Razer6 added this to the 7.4 milestone Sep 27, 2014

Razer6 added a commit that referenced this pull request Sep 27, 2014

Merge pull request #7864 from cirosantilli/rm-default-type-submit
Remove type submit from button_tag since default.

@Razer6 Razer6 merged commit c2c41fb into gitlabhq:master Sep 27, 2014

1 check failed

default The build failed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-default-type-submit branch Sep 27, 2014

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Nov 6, 2018

Merge branch '7864-ee-routes-ee' into 'master'
Put EE routes in EE files under EE directories

Closes gitlabhq#7864

See merge request gitlab-org/gitlab-ee!7935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment