Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use button type=submit instead of input. #7866

Merged
merged 1 commit into from Oct 28, 2014

Conversation

4 participants
@cirosantilli
Copy link
Contributor

commented Sep 26, 2014

This PR replaces all input type="submit" (generated by submit_tag) with button type="submit".

Starting from IE7 they are the same, and button is more flexible as it can contain HTML. Let's use button everywhere then: http://stackoverflow.com/questions/7117639/input-type-submit-vs-button-tag-are-they-interchangeable

Note: Rails adds type="submit" by default to button_tag.

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 26, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:input-button-to-tag branch from d4552eb to 6294033 Oct 1, 2014

@Razer6 Razer6 added this to the 7.4 milestone Oct 13, 2014

@dzaporozhets dzaporozhets modified the milestones: 7.4, 7.5 Oct 15, 2014

dzaporozhets added a commit that referenced this pull request Oct 28, 2014

Merge pull request #7866 from cirosantilli/input-button-to-tag
Use button type=submit instead of input.

@dzaporozhets dzaporozhets merged commit b23b78a into gitlabhq:master Oct 28, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:input-button-to-tag branch Oct 28, 2014

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Jan 3, 2019

Merge branch '7866-fix-epics-promotion-helper' into 'master'
Remove epics field for projects not in groups

Closes gitlabhq#7866

See merge request gitlab-org/gitlab-ee!8919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.