Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo indiciated -> indicated. #7875

Merged
merged 1 commit into from Sep 27, 2014

Conversation

4 participants
@cirosantilli
Copy link
Contributor

commented Sep 27, 2014

No description provided.

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 27, 2014

I've prepared a stage. Click to open.

@seuros

This comment has been minimized.

Copy link

commented Sep 27, 2014

Please add [ci skip] to the commit message when updating no code .

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2014

I agree that may be a good procedure if builds are very slow, but:

  • it has only been done once so far
  • pollutes commit messages

so I'm not sure what is the best thing to do for now.

Consider opening a PR to propose that on the CONTRIBUTING so we can reach consensus.

@seuros

This comment has been minimized.

Copy link

commented Sep 27, 2014

The title or body of the pr works too.

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2014

Ah, I didn't know that: in that case, it is really worth it, specially in the PR body.

Can you find where it is documented?

Razer6 added a commit that referenced this pull request Sep 27, 2014

Merge pull request #7875 from cirosantilli/patch-6
Typo indiciated -> indicated.

@Razer6 Razer6 merged commit 37a68ea into gitlabhq:master Sep 27, 2014

1 check failed

default The build failed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:patch-6 branch Sep 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.