Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace :erb filter with plain HAML. #7880

Merged
merged 1 commit into from Oct 2, 2014

Conversation

3 participants
@cirosantilli
Copy link
Contributor

commented Sep 27, 2014

Rendered HTML is the same.

We use HAML exactly avoid ERB or pure HTML, so let's not use :erb.

There is another occurrence which I cannot get rid of at:

because of haml/haml#648

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 27, 2014

I've prepared a stage. Click to open.

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2014

Failure unrelated.

@cirosantilli cirosantilli force-pushed the cirosantilli:replace-erb-haml branch from 8417020 to 5f10ef7 Oct 1, 2014

Razer6 added a commit that referenced this pull request Oct 2, 2014

Merge pull request #7880 from cirosantilli/replace-erb-haml
Replace :erb filter with plain HAML.

@Razer6 Razer6 merged commit 8d1137c into gitlabhq:master Oct 2, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:replace-erb-haml branch Oct 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.