New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blame lines added leading whitespace. #7881

Merged
merged 1 commit into from Oct 2, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Sep 27, 2014

This was adding 2 extra spaces to the blame.

Before: (there are two whitespaces before every line content)

screenshot from 2014-09-27 16 47 19 blame whitespace before

After:

screenshot from 2014-09-27 16 47 34 blame whitespace after

I think the new spacing is fine: if we want to control it let's do it with CSS.

I really wanted to get rid of that :erb block but I was not able to as mentioned in #7880

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 27, 2014

I've prepared a stage. Click to open.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 28, 2014

Failure unrelated.

@cirosantilli cirosantilli force-pushed the cirosantilli:rm-blame-extra-white branch from 565e3b9 to b7160cb Oct 1, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Oct 2, 2014

❤️ that on my 1280px screen

Razer6 added a commit that referenced this pull request Oct 2, 2014

Merge pull request #7881 from cirosantilli/rm-blame-extra-white
Remove blame lines added leading whitespace.

@Razer6 Razer6 merged commit 4b6bbf9 into gitlabhq:master Oct 2, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:rm-blame-extra-white branch Oct 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment