New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blob local instead of instance. #7882

Merged
merged 1 commit into from Dec 20, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Sep 27, 2014

It is open to discussion which is the better style, to use instance variables @blob on partials or only locals, but mixing both like here is definitely not the way to go.

http://stackoverflow.com/questions/2503838/rails-should-partials-be-aware-of-instance-variables

Modified to a local since it is the only occurrence of @blob, and there are many other blob in the same file.

Other variables however are predominantly instance.

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 27, 2014

I've prepared a stage. Click to open.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 28, 2014

Failure unrelated.

@cirosantilli cirosantilli force-pushed the cirosantilli:blob-instance-to-local branch from 7f35a25 to e2e4dc5 Oct 1, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Dec 13, 2014

@cirosantilli Thanks :)

dzaporozhets added a commit that referenced this pull request Dec 20, 2014

Merge pull request #7882 from cirosantilli/blob-instance-to-local
Use blob local instead of instance.

@dzaporozhets dzaporozhets merged commit dc0879a into gitlabhq:master Dec 20, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:blob-instance-to-local branch Dec 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment