Skip to content

Conversation

@cirosantilli
Copy link
Contributor

This PR adds 2 tests for the blob edit link state:

  • If the file is binary the edit link is hidden
  • If I don't have edit permission the edit link is disabled

I felt the need for that while doing: #7886

@TeatroIO
Copy link

I've prepared a stage. Click to open.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

@cirosantilli cirosantilli force-pushed the edit-blob-link-tests branch 2 times, most recently from 8bee952 to 520e7a7 Compare October 1, 2014 06:57
@jvanbaarsen
Copy link
Contributor

@cirosantilli Can you please make this mergeable again?

@cirosantilli cirosantilli changed the title Add tests for disabled blob edit button cases. Add tests for disabled blob edit button cases [WIP] Dec 4, 2014
@jvanbaarsen jvanbaarsen changed the title Add tests for disabled blob edit button cases [WIP] [WIP] Add tests for disabled blob edit button cases Dec 13, 2014
@jvanbaarsen
Copy link
Contributor

@cirosantilli Are you still working on this?

@cirosantilli cirosantilli changed the title [WIP] Add tests for disabled blob edit button cases Add tests for disabled blob edit button cases [Can be updated] Dec 13, 2014
@cirosantilli
Copy link
Contributor Author

If I finish it I'll reopen.

@jvanbaarsen
Copy link
Contributor

Thanks :-)

On Sat, Dec 13, 2014 at 9:52 PM, Ciro Santilli notifications@github.com
wrote:

Closed #7887.

Reply to this email directly or view it on GitHub:
#7887 (comment)

@cirosantilli
Copy link
Contributor Author

@jvanbaarsen updated at: #8520

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Nov 6, 2018
Fix disappearing weight input in Firefox

Closes gitlabhq#7887

See merge request gitlab-org/gitlab-ee!7869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants