New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev user seed: ID was used twice. #7894

Merged
merged 1 commit into from Dec 20, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Sep 29, 2014

Was causing the command rake gitlab:setup to fail if you run it twice.

Cause: the user count was incremented above from 10 to 20, and the seed below was not DRY (repeated 10) and was not changed. Now it is DRY.

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 29, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Fix dev user seed: multiple ID was used twice. to [WIP] Fix dev user seed: multiple ID was used twice. Sep 29, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:fix-dev-user-seed branch from 1bebb90 to 42d53c0 Sep 29, 2014

@cirosantilli cirosantilli changed the title from [WIP] Fix dev user seed: multiple ID was used twice. to [WIP] Fix dev user seed: ID was used twice. Sep 29, 2014

@cirosantilli cirosantilli changed the title from [WIP] Fix dev user seed: ID was used twice. to Fix dev user seed: ID was used twice. Sep 29, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Sep 29, 2014

Failure unrelated.

@cirosantilli cirosantilli force-pushed the cirosantilli:fix-dev-user-seed branch from 42d53c0 to 083f1e2 Sep 30, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Dec 13, 2014

@cirosantilli Thanks :)

dzaporozhets added a commit that referenced this pull request Dec 20, 2014

Merge pull request #7894 from cirosantilli/fix-dev-user-seed
Fix dev user seed: ID was used twice.

@dzaporozhets dzaporozhets merged commit 223e509 into gitlabhq:master Dec 20, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:fix-dev-user-seed branch Dec 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment