New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent email sending on admin dev seed. #7895

Merged
merged 1 commit into from Sep 29, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Sep 29, 2014

The only advantage of having emails is for first time developers to find the password more easily... but I think it is not worth it because:

  • it forces every dev (large majority of which not a first time dev) to close those email tabs on every gitlab:setup
  • it is already well documented on the dev install

So let's nuke them.

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 29, 2014

I've prepared a stage. Click to open.

Gitlab::Seeder.quiet do
User.seed do |s|
s.id = 1
s.name = "Administrator"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 29, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

User.seed do |s|
s.id = 1
s.name = "Administrator"
s.email = "admin@example.com"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 29, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

s.name = "Administrator"
s.email = "admin@example.com"
s.username = 'root'
s.password = "5iveL!fe"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 29, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

s.email = "admin@example.com"
s.username = 'root'
s.password = "5iveL!fe"
s.password_confirmation = "5iveL!fe"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 29, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@cirosantilli cirosantilli force-pushed the cirosantilli:quiet-admin-dev-seed branch from bf79a9f to a963e8c Sep 29, 2014

dzaporozhets added a commit that referenced this pull request Sep 29, 2014

Merge pull request #7895 from cirosantilli/quiet-admin-dev-seed
Prevent email sending on admin dev seed.

@dzaporozhets dzaporozhets merged commit 35152e3 into gitlabhq:master Sep 29, 2014

1 check failed

default The build failed on Semaphore.
Details
@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Sep 29, 2014

Yeah. Its annoying to close this window every time you run seeds

@cirosantilli cirosantilli deleted the cirosantilli:quiet-admin-dev-seed branch Sep 29, 2014

dbalexandre pushed a commit that referenced this pull request Dec 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment