Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert many JavaScript # links to buttons [failure unrelated] #7912

Merged
merged 1 commit into from Mar 3, 2015

Conversation

5 participants
@cirosantilli
Copy link
Contributor

commented Sep 30, 2014

Same rationale as: #7863

Found with git grep "'#'".

Refactored for every place except projects.

Only touched buttons that look like buttons, not links. Those should work with .btn.btn-link but for some reason didn't.

There were several dropdown ones factored with:

find . -iname '*.haml' | xargs perl -lapi -e "s/%a.dropdown-toggle.btn{href: '#', \"data-toggle\" => \"dropdown\"}/%button.dropdown-toggle.btn{type: 'button', 'data-toggle' => 'dropdown'}/"

We should really DRY up those dropboxes before they start diverging.

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 30, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title Convert Javascript links to buttons. Convert many Javascript links to buttons. Sep 30, 2014

@cirosantilli cirosantilli changed the title Convert many Javascript links to buttons. Convert many Javascript # links to buttons. Sep 30, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:link-to-button branch from 0af1b0e to 097b250 Sep 30, 2014

@cirosantilli cirosantilli changed the title Convert many Javascript # links to buttons. [WIP] Convert many Javascript # links to buttons. Sep 30, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:link-to-button branch from 097b250 to a8c20b7 Sep 30, 2014

@cirosantilli cirosantilli changed the title [WIP] Convert many Javascript # links to buttons. Convert many Javascript # links to buttons. Sep 30, 2014

@jvanbaarsen

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2014

@cirosantilli Can you please make this mergeable again?

@cirosantilli cirosantilli force-pushed the cirosantilli:link-to-button branch from a8c20b7 to 0ca0680 Dec 30, 2014

@cirosantilli cirosantilli changed the title Convert many Javascript # links to buttons. [WIP] Convert many Javascript # links to buttons. Dec 30, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:link-to-button branch 2 times, most recently from e6c5349 to bc12804 Dec 30, 2014

@cirosantilli cirosantilli changed the title [WIP] Convert many Javascript # links to buttons. Convert many Javascript # links to buttons. Dec 30, 2014

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Dec 30, 2014

@jvanbaarsen updated.

@jvanbaarsen jvanbaarsen added this to the 7.7 milestone Jan 4, 2015

@dzaporozhets dzaporozhets modified the milestones: 7.7, 7.8 Jan 13, 2015

@dblessing

This comment has been minimized.

Copy link
Member

commented Jan 17, 2015

@cirosantilli It looks like this can be pulled into 7.8 if you can please rebase.

@cirosantilli cirosantilli force-pushed the cirosantilli:link-to-button branch from bc12804 to 55d9809 Jan 17, 2015

@cirosantilli cirosantilli changed the title Convert many Javascript # links to buttons. [WIP] Convert many Javascript # links to buttons. Jan 17, 2015

@cirosantilli cirosantilli changed the title [WIP] Convert many Javascript # links to buttons. Convert many Javascript # links to buttons Jan 17, 2015

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2015

@dblessing failure does not happen locally

@cirosantilli cirosantilli changed the title Convert many Javascript # links to buttons Convert many Javascript # links to buttons [failure unrelated] Jan 17, 2015

@dzaporozhets dzaporozhets merged commit 55d9809 into gitlabhq:master Mar 3, 2015

2 checks passed

hound Hound has reviewed the changes.
semaphoreci The build passed on Semaphore.
Details

dzaporozhets added a commit that referenced this pull request Mar 3, 2015

Merge branch 'cirosantilli-link-to-button' into 'master'
Cirosantilli link to button

For #7912

See merge request !1614

@cirosantilli cirosantilli changed the title Convert many Javascript # links to buttons [failure unrelated] Convert many JavaScript # links to buttons [failure unrelated] Mar 3, 2015

@cirosantilli cirosantilli deleted the cirosantilli:link-to-button branch Mar 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.