Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor commit message textareas #7919

Merged

Conversation

4 participants
@cirosantilli
Copy link
Contributor

commented Sep 30, 2014

Same thing as before in less lines. ;)

Factors out the commit message textareas from new file, edit file, remove file and merge request custom msg.

The only change in HTML is not noticeable for end users: merge_commit_message was moved to commit_message to match other textareas and be DRYer.

@TeatroIO

This comment has been minimized.

Copy link

commented Sep 30, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-commit-msg-textarea branch from 2fec330 to 47c1953 Sep 30, 2014

@cirosantilli cirosantilli changed the title Factor commit message textareas. Factor commit message textareas [failure unrelated] Sep 30, 2014

@Razer6

This comment has been minimized.

Copy link
Member

commented Oct 2, 2014

@cirosantilli Can you rebase?

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-commit-msg-textarea branch from 47c1953 to 3098e7a Oct 2, 2014

@cirosantilli cirosantilli changed the title Factor commit message textareas [failure unrelated] [WIP] Factor commit message textareas Oct 2, 2014

@cirosantilli cirosantilli changed the title [WIP] Factor commit message textareas Factor commit message textareas Oct 2, 2014

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2014

Done.

@Razer6 Razer6 added this to the 7.4 milestone Oct 2, 2014

@dzaporozhets dzaporozhets merged commit 3098e7a into gitlabhq:master Oct 3, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:factor-commit-msg-textarea branch Oct 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.