New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve remove file commit message textarea placeholder. #7922

Merged
merged 1 commit into from Oct 2, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Sep 30, 2014

Advantages:

  • imperative Remove, which is the more common practice
  • add filename, which makes it clear what is being done, and matches the update placeholder which says Update filename
@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 30, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Improve remove file textarea placeholder. to Improve remove file oommit message textarea placeholder. Sep 30, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Oct 2, 2014

👍

Razer6 added a commit that referenced this pull request Oct 2, 2014

Merge pull request #7922 from cirosantilli/improve-remove-file-commit…
…-placeholder

Improve remove file oommit message textarea placeholder.

@Razer6 Razer6 merged commit 06fd4bf into gitlabhq:master Oct 2, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli changed the title from Improve remove file oommit message textarea placeholder. to Improve remove file ommit message textarea placeholder. Oct 2, 2014

@cirosantilli cirosantilli changed the title from Improve remove file ommit message textarea placeholder. to Improve remove file commit message textarea placeholder. Oct 2, 2014

@cirosantilli cirosantilli deleted the cirosantilli:improve-remove-file-commit-placeholder branch Oct 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment