New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor dashboard helper methods. #7938

Merged
merged 1 commit into from Oct 8, 2014

Conversation

5 participants
@cirosantilli
Contributor

cirosantilli commented Oct 2, 2014

Same thing, less lines.

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 2, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title from Factor dashboard helper methods. to [WIP] Factor dashboard helper methods. Oct 2, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-dashboard-helper branch 8 times, most recently from f42e92c to 94e8e1e Oct 2, 2014

def get_items(items, scope, prefix = '', get_authorized = false)

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2014

Unused method argument - prefix. If it's necessary, use _ or _prefix as an argument name to indicate that it won't be used.

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-dashboard-helper branch from 94e8e1e to 2d8e250 Oct 2, 2014

def get_items(items, scope, prefix = '', get_authorized = false)

This comment has been minimized.

@houndci-bot

houndci-bot Oct 2, 2014

Unused method argument - prefix. If it's necessary, use _ or _prefix as an argument name to indicate that it won't be used.

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-dashboard-helper branch 4 times, most recently from 6fdafa5 to 3f87993 Oct 2, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:factor-dashboard-helper branch from 3f87993 to da99560 Oct 2, 2014

@cirosantilli cirosantilli changed the title from [WIP] Factor dashboard helper methods. to Factor dashboard helper methods. Oct 2, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Oct 6, 2014

@randx looks good!

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Oct 8, 2014

nice!

dzaporozhets added a commit that referenced this pull request Oct 8, 2014

@dzaporozhets dzaporozhets merged commit ac7fab7 into gitlabhq:master Oct 8, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:factor-dashboard-helper branch Oct 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment