New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Spinach test names consistent [failure unrelated] #7940

Merged
merged 1 commit into from Oct 5, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Oct 2, 2014

  • do not add Feature to feature titles
  • titleize feature titles
  • put steps on the same path as .feature files
  • make feature titles match their path

I've played enough the Where is my step? Grep! game =)

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 2, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:uniform-spinach-names branch from 7947c4d to ca7c7d5 Oct 2, 2014

@cirosantilli cirosantilli changed the title from [WIP] Make Spinach test names consistent to Make Spinach test names consistent Oct 2, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Oct 5, 2014

Sounds reasonable! Can you rebase, then I'll merge.

Make Spinach test names consistent
- do not add Feature to feature titles
- titleize feature titles
- put steps on the same path as .feature files
- make feature titles match their path

@cirosantilli cirosantilli force-pushed the cirosantilli:uniform-spinach-names branch from ca7c7d5 to fa34901 Oct 5, 2014

@cirosantilli cirosantilli changed the title from Make Spinach test names consistent to Make Spinach test names consistent [failure unrelated] Oct 5, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Oct 5, 2014

Done! Failure unrelated.

Razer6 added a commit that referenced this pull request Oct 5, 2014

Merge pull request #7940 from cirosantilli/uniform-spinach-names
Make Spinach test names consistent [failure unrelated]

@Razer6 Razer6 merged commit ff43500 into gitlabhq:master Oct 5, 2014

1 check failed

default The build failed on Semaphore.
Details
@Razer6

This comment has been minimized.

Member

Razer6 commented Oct 5, 2014

👍

@cirosantilli cirosantilli deleted the cirosantilli:uniform-spinach-names branch Oct 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment