New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move new blob commit message textarea below editor #7944

Merged
merged 1 commit into from Nov 11, 2014

Conversation

5 participants
@cirosantilli
Contributor

cirosantilli commented Oct 2, 2014

  • match edit blob view
  • you enter the commit message after you make the modifications

After:

screenshot from 2014-10-03 00 28 09 new blob commit below after

Before:

screenshot from 2014-10-03 00 27 49 new blob commit below before

@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 2, 2014

I've prepared a stage. Click to open.

@Razer6

This comment has been minimized.

Member

Razer6 commented Oct 13, 2014

@cirosantilli Makes sense. Could you rebase?

@Razer6 Razer6 added this to the 7.4 milestone Oct 13, 2014

Move new blob commit message textarea below editor
- match edit blob view
- you enter the commit message *after* you make the modifications

@cirosantilli cirosantilli force-pushed the cirosantilli:new-blob-commit-below branch from 0b811c3 to d584c40 Oct 13, 2014

@cirosantilli cirosantilli changed the title from Move new blob commit message textarea below editor to [WIP] Move new blob commit message textarea below editor Oct 13, 2014

@cirosantilli cirosantilli changed the title from [WIP] Move new blob commit message textarea below editor to Move new blob commit message textarea below editor Oct 13, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Oct 13, 2014

@Razer6 done.

@dzaporozhets dzaporozhets modified the milestones: 7.4, 7.5 Oct 15, 2014

@vsizov

This comment has been minimized.

Contributor

vsizov commented Nov 5, 2014

@randx What do you think on this?

@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Nov 5, 2014

It makes sense for consistency with Edit

dzaporozhets added a commit that referenced this pull request Nov 11, 2014

Merge pull request #7944 from cirosantilli/new-blob-commit-below
Move new blob commit message textarea below editor

@dzaporozhets dzaporozhets merged commit a6f48ae into gitlabhq:master Nov 11, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:new-blob-commit-below branch Nov 11, 2014

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Nov 6, 2018

Merge branch '7944-fix-resolve-checkbox-text-color' into 'master'
Fix color of text in resolution checkbox

Closes gitlabhq#7944

See merge request gitlab-org/gitlab-ee!7975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment